improving performance of big polygons parsing #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a functional fix for polygon parsing; the bug that is addressed by the fix is that polygons with > 1000 lines take a long time to parse. This is because the loop goes through the polygon parsing for each coordinate entry: this is unnecessary and degrades performance a lot: more coordinates results in more unnecessary loops. The fix cuts the loop for polygons after the first parsing. Of course, this is a sort of a hack ... the correct way to fix this would be to follow the top-down structure of the kml instead of looping directly over all coordinates, just to go back to the parent, parse the parent and then do it all over again ...
CyberDracula
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a functional fix for polygon parsing; the bug that is addressed by the fix is that polygons with > 1000 lines take a long time to parse.
This is because the loop goes through the polygon parsing for each coordinate entry: this is unnecessary and degrades performance a lot: more coordinates results in more unnecessary loops.
The fix cuts the loop for polygons after the first parsing.
Of course, this is a sort of a hack ... the correct way to fix this would be to follow the top-down structure of the kml instead of looping directly over all coordinates, just to go back to the parent, parse the parent and then do it all over again ...