fix: bazaar installed pill color #71
Conversation
readability of the installed pill should be better now due to the lack of transparency
doesn't slightly cut off their heads anymore
renner0e
requested review from
NiHaiden,
hanthor,
inffy and
ledif
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes the color of the 'installed' pill in the bazaar. The changes involve adding new CSS rules to style the pill differently for various sections and adjusting banner heights for better visual consistency. My review focuses on improving the maintainability of the new CSS by removing redundant property declarations. Overall, the changes look good and address the intended fix.
| .dev-section app-tile-installed-pill { | ||
| background-color: #cbabff; | ||
| color: var(--fg-color); |
There was a problem hiding this comment.
The color: var(--fg-color); property is redundant here. It's already defined in the .global-section app-tile-installed-pill rule at line 50. Since elements with .dev-section also have the .global-section class, the color property will be applied from that more general rule. Removing this duplication improves maintainability by following the DRY (Don't Repeat Yourself) principle.
| .dev-section-dark app-tile-installed-pill { | ||
| background-color: #084152; | ||
| color: var(--fg-color); |
There was a problem hiding this comment.
Similar to the .dev-section rule, this color: var(--fg-color); property is redundant. The color is already set by the .global-section app-tile-installed-pill rule (line 50). Removing this line will make the CSS cleaner and easier to maintain.
Screencast_20260101_035740.webm