Skip to content

Conversation

@renner0e
Copy link
Collaborator

@renner0e renner0e commented Jan 4, 2026

This is already defined in ublue-fastfetch which we get from bluefin. Fish alias is fine to remove as well for exactly the same reason.

Tested by removing the files and spawning a login shell with fish and running neofetch and it works as expected.

https://github.com/projectbluefin/common/blob/bf18df7ce7d2276587f1137f258b49ada6d833c4/system_files/shared/etc/profile.d/ublue-fastfetch.sh

This is already defined in ublue-fastfetch which we get from bluefin.
Fish alias is fine to remove as well for exactly the same reason.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two files, neofetch.sh and neofetch.fish, which provided an alias from neofetch to fastfetch. The rationale is that these aliases are redundant, as they are already defined in ublue-fastfetch. This is a good cleanup to remove duplicated configuration. The change is straightforward and appears correct based on the provided context.

@inffy inffy added this pull request to the merge queue Jan 4, 2026
Merged via the queue into main with commit 6191f1d Jan 4, 2026
1 check passed
@inffy inffy deleted the cleanup-neofetch branch January 4, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants