Skip to content

Conversation

@cychuang0924
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

Checklist

  • Fork the repository and create your new branch from master.
  • Please mention the name of community in Pull Request title.
  • Git Commit Messages
    • Use the present tense (Also in Pull Request title): "Add feature" not "Added feature"
    • Use the imperative mood (Also in Pull Request title): "Move cursor to..." not "Moves cursor to..."
    • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

@cychuang0924 cychuang0924 force-pushed the addSelfEd25519AndMethod branch from 64802c0 to 59bd901 Compare November 25, 2024 09:46
@unaeat unaeat force-pushed the addSelfEd25519AndMethod branch from 12b7a0e to 22d05b2 Compare November 26, 2024 08:18
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 16.60984% with 1712 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (c70f57c) to head (22d05b2).

Files with missing lines Patch % Lines
...o/elliptic/ed25519prue/edwards25519/scalar_fiat.go 0.00% 943 Missing ⚠️
.../elliptic/ed25519prue/edwards25519/edwards25519.go 0.00% 209 Missing ⚠️
crypto/elliptic/ed25519prue/ed25519.go 0.00% 163 Missing ⚠️
crypto/elliptic/ed25519prue/edwards25519/scalar.go 0.00% 133 Missing ⚠️
crypto/elliptic/ed25519prue/byte/byteorder.go 0.00% 106 Missing ⚠️
...to/elliptic/ed25519prue/edwards25519/scalarmult.go 0.00% 100 Missing ⚠️
crypto/elliptic/ed25519prue/edwards25519/tables.go 0.00% 48 Missing ⚠️
...ypto/elliptic/ed25519prue/edwards25519/field/fe.go 96.47% 7 Missing and 1 partial ⚠️
crypto/elliptic/ed25519.go 66.66% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (c70f57c) and HEAD (22d05b2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c70f57c) HEAD (22d05b2)
3 2
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   75.92%   66.94%   -8.98%     
==========================================
  Files         152      162      +10     
  Lines       11532    13579    +2047     
==========================================
+ Hits         8756     9091     +335     
- Misses       2016     3726    +1710     
- Partials      760      762       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cychuang0924 cychuang0924 force-pushed the addSelfEd25519AndMethod branch from 22d05b2 to d16dc72 Compare November 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants