Conversation
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/frontend/src/components/command-menu.tsx">
<violation number="1" location="apps/frontend/src/components/command-menu.tsx:154">
P1: Bug: "No results found" empty state can never be displayed. `visibleActions` always has at least 3 items (General Settings, Project Settings, Switch Mode), so `visibleActions.length === 0` is always false. The condition should likely just check for the absence of search results without gating on action commands, e.g. `!hasSearchResults && !isPendingSearch && isSearchMode`.</violation>
</file>
<file name="apps/frontend/src/components/sidebar-user-menu.tsx">
<violation number="1" location="apps/frontend/src/components/sidebar-user-menu.tsx:86">
P2: Unhandled promise rejection: `signOut()` returns a promise that is neither awaited nor caught. If the sign-out request fails (e.g., network error), the user gets no feedback and an unhandled rejection is logged. Consider handling the error to show a toast or retry.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Pull request overview
Restructures the frontend command palette and sidebar UI to improve navigation and chat search usability, adding recents, grouped commands, and new sidebar actions.
Changes:
- Command palette: split into “Jump to” vs “Actions”, add “Recent” chats, add search-result highlighting, and replace “Searching…” with
TextShimmer. - Sidebar: replace outlined buttons with flat “New Chat” and “Search” items, add a “Recents” label, and add a user dropdown menu with settings sub-pages and logout.
- Lockfiles updated (
package-lock.json,cli/uv.lock), including new Python/CLI extras (e.g., Trino) and npm lockfile metadata changes.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Lockfile metadata churn (e.g., dev → devOptional, removed peer flags). |
| cli/uv.lock | Adds ibis-framework trino extra and new resolved packages (trino, orjson, zstandard, etc.). |
| apps/frontend/src/components/ui/command.tsx | Widens command dialog and increases list height; updates selector syntax. |
| apps/frontend/src/components/sidebar.tsx | Adds flat sidebar items for New Chat/Search and adds a “Recents” label above chat list. |
| apps/frontend/src/components/sidebar-user-menu.tsx | Replaces settings link with dropdown menu for settings sub-pages + logout. |
| apps/frontend/src/components/command-menu.tsx | Adds open helper, recent chats section, search highlighting, shimmer loading state, and regrouped commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Bl3f Surething! happy to wait for the menu reorganisation. Let me know if there's anything I can pick up in the meantime! |
|
Hello @Rish-it would it be possible for you to rebase with main and adapt the code so we keep the only the changes that you've done in the command menu and not what you did in the sidebar. Also I'd not put the recent chats by default in the command menu, because it makes it a bit to high. |
feat(ui): restructure command palette and sidebar
Summary
Overhauls the command palette and sidebar to be cleaner and more functional.
Closes #302
Command Palette
TextShimmeranimationopenCommandMenu()helper for triggering from the sidebar Search buttonsm:max-w-2xl) and increased list height (max-h-[500px])command.tsxCSS selectors to use**:[[attr]]syntaxSidebar
Visuals
Screen.Recording.2026-02-26.at.1.20.38.PM.mov
Pros
DropdownMenu,TextShimmer,Separator)Cons
Test Plan
npm run lintand Prettier pass