Skip to content

Add boxlite to run Python + deps#373

Open
Bl3f wants to merge 1 commit intomainfrom
feat/boxlite
Open

Add boxlite to run Python + deps#373
Bl3f wants to merge 1 commit intomainfrom
feat/boxlite

Conversation

@Bl3f
Copy link
Contributor

@Bl3f Bl3f commented Feb 26, 2026

No description provided.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 issues found across 18 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/backend/src/trpc/project.routes.ts">

<violation number="1" location="apps/backend/src/trpc/project.routes.ts:295">
P2: The new `sandboxes` experimental setting is not tracked in the PostHog event for `ProjectAgentSettingsUpdated`, unlike the analogous `pythonSandboxing` setting. Consider adding `sandboxes_enabled: merged.experimental?.sandboxes` to the PostHog capture call in `updateAgentSettings`.</violation>
</file>

<file name="apps/backend/src/agents/tools/execute-sandboxed-code.ts">

<violation number="1" location="apps/backend/src/agents/tools/execute-sandboxed-code.ts:85">
P1: Path traversal vulnerability: `filename` from agent input is used unsanitized in `path.join(tmpDir, filename)` and `fs.writeFileSync`. A filename like `../../etc/foo` would write files outside the temp directory on the host filesystem. Sanitize by stripping directory components (e.g., `path.basename(filename)`).</violation>
</file>

<file name="apps/frontend/src/components/ui/settings-toggle-row.tsx">

<violation number="1" location="apps/frontend/src/components/ui/settings-toggle-row.tsx:6">
P2: `description` is rendered inside a `<p>` tag (line 24), but the type now allows arbitrary `React.ReactNode`. If a caller passes block-level elements (e.g., `<div>`, `<p>`), this produces invalid nested HTML and React hydration errors. Consider changing the wrapper from `<p>` to `<div>` or `<span>`, or narrowing the type to `string | React.ReactElement<HTMLSpanElement>`.</violation>
</file>

<file name="apps/frontend/src/styles.css">

<violation number="1" location="apps/frontend/src/styles.css:52">
P1: Bug: CSS variable name accidentally truncated — `--color-accent-foreground` was changed to `--color-accent-`. This breaks the Tailwind theme token for `accent-foreground`, meaning any utility class referencing this color (e.g., `text-accent-foreground`) will no longer resolve correctly.</violation>
</file>

<file name="apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx">

<violation number="1" location="apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx:72">
P2: Rendering bug: `(packages?.length || dataFiles?.length) && (...)` can render a literal `0` when both arrays are empty. Use boolean coercion: `(!!packages?.length || !!dataFiles?.length)`.</violation>

<violation number="2" location="apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx:74">
P2: Rendering bug: `packages?.length && (...)` will render a literal `0` in the DOM when `packages` is an empty array. Use a boolean coercion (`!!packages?.length`) or a ternary to avoid this.</violation>

<violation number="3" location="apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx:80">
P2: Same rendering bug: `dataFiles?.length && (...)` will render a literal `0` when `dataFiles` is an empty array. Use `!!dataFiles?.length` or a ternary.</violation>
</file>

<file name="apps/frontend/src/components/settings/experimental.tsx">

<violation number="1" location="apps/frontend/src/components/settings/experimental.tsx:80">
P2: Missing `rel='noopener noreferrer'` on `target='_blank'` link. The existing codebase pattern (e.g., `slack-config-section.tsx`) consistently includes this attribute on external links for security hardening.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

}

const csvContent = queryResultToCsv(result);
const hostPath = path.join(tmpDir, filename);
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Path traversal vulnerability: filename from agent input is used unsanitized in path.join(tmpDir, filename) and fs.writeFileSync. A filename like ../../etc/foo would write files outside the temp directory on the host filesystem. Sanitize by stripping directory components (e.g., path.basename(filename)).

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/src/agents/tools/execute-sandboxed-code.ts, line 85:

<comment>Path traversal vulnerability: `filename` from agent input is used unsanitized in `path.join(tmpDir, filename)` and `fs.writeFileSync`. A filename like `../../etc/foo` would write files outside the temp directory on the host filesystem. Sanitize by stripping directory components (e.g., `path.basename(filename)`).</comment>

<file context>
@@ -0,0 +1,129 @@
+				}
+
+				const csvContent = queryResultToCsv(result);
+				const hostPath = path.join(tmpDir, filename);
+				fs.writeFileSync(hostPath, csvContent, 'utf-8');
+				await box.copyIn(hostPath, `${WORKING_DIR}/${filename}`);
</file context>
Fix with Cubic

--color-muted-foreground: var(--muted-foreground);
--color-accent: var(--accent);
--color-accent-foreground: var(--accent-foreground);
--color-accent-: var(--accent-foreground);
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Bug: CSS variable name accidentally truncated — --color-accent-foreground was changed to --color-accent-. This breaks the Tailwind theme token for accent-foreground, meaning any utility class referencing this color (e.g., text-accent-foreground) will no longer resolve correctly.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/frontend/src/styles.css, line 52:

<comment>Bug: CSS variable name accidentally truncated — `--color-accent-foreground` was changed to `--color-accent-`. This breaks the Tailwind theme token for `accent-foreground`, meaning any utility class referencing this color (e.g., `text-accent-foreground`) will no longer resolve correctly.</comment>

<file context>
@@ -49,7 +49,7 @@ code {
 	--color-muted-foreground: var(--muted-foreground);
 	--color-accent: var(--accent);
-	--color-accent-foreground: var(--accent-foreground);
+	--color-accent-: var(--accent-foreground);
 	--color-destructive: var(--destructive);
 	--color-border: var(--border);
</file context>
Suggested change
--color-accent-: var(--accent-foreground);
--color-accent-foreground: var(--accent-foreground);
Fix with Cubic

experimental: z
.object({
pythonSandboxing: z.boolean().optional(),
sandboxes: z.boolean().optional(),
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The new sandboxes experimental setting is not tracked in the PostHog event for ProjectAgentSettingsUpdated, unlike the analogous pythonSandboxing setting. Consider adding sandboxes_enabled: merged.experimental?.sandboxes to the PostHog capture call in updateAgentSettings.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/src/trpc/project.routes.ts, line 295:

<comment>The new `sandboxes` experimental setting is not tracked in the PostHog event for `ProjectAgentSettingsUpdated`, unlike the analogous `pythonSandboxing` setting. Consider adding `sandboxes_enabled: merged.experimental?.sandboxes` to the PostHog capture call in `updateAgentSettings`.</comment>

<file context>
@@ -291,6 +292,7 @@ export const projectRoutes = {
 				experimental: z
 					.object({
 						pythonSandboxing: z.boolean().optional(),
+						sandboxes: z.boolean().optional(),
 					})
 					.optional(),
</file context>
Fix with Cubic

interface SettingsControlRowProps {
label: string;
description: string;
description: string | React.ReactNode;
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: description is rendered inside a <p> tag (line 24), but the type now allows arbitrary React.ReactNode. If a caller passes block-level elements (e.g., <div>, <p>), this produces invalid nested HTML and React hydration errors. Consider changing the wrapper from <p> to <div> or <span>, or narrowing the type to string | React.ReactElement<HTMLSpanElement>.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/frontend/src/components/ui/settings-toggle-row.tsx, line 6:

<comment>`description` is rendered inside a `<p>` tag (line 24), but the type now allows arbitrary `React.ReactNode`. If a caller passes block-level elements (e.g., `<div>`, `<p>`), this produces invalid nested HTML and React hydration errors. Consider changing the wrapper from `<p>` to `<div>` or `<span>`, or narrowing the type to `string | React.ReactElement<HTMLSpanElement>`.</comment>

<file context>
@@ -3,7 +3,7 @@ import { cn } from '@/lib/utils';
 interface SettingsControlRowProps {
 	label: string;
-	description: string;
+	description: string | React.ReactNode;
 	control: React.ReactNode;
 	id?: string;
</file context>
Fix with Cubic

>
{viewMode === 'code' ? (
<div className='overflow-auto max-h-80'>
{(packages?.length || dataFiles?.length) && (
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Rendering bug: (packages?.length || dataFiles?.length) && (...) can render a literal 0 when both arrays are empty. Use boolean coercion: (!!packages?.length || !!dataFiles?.length).

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx, line 72:

<comment>Rendering bug: `(packages?.length || dataFiles?.length) && (...)` can render a literal `0` when both arrays are empty. Use boolean coercion: `(!!packages?.length || !!dataFiles?.length)`.</comment>

<file context>
@@ -0,0 +1,124 @@
+		>
+			{viewMode === 'code' ? (
+				<div className='overflow-auto max-h-80'>
+					{(packages?.length || dataFiles?.length) && (
+						<div className='flex flex-wrap gap-2 px-3 py-2 border-b border-border text-xs text-foreground/60'>
+							{packages?.length && (
</file context>
Fix with Cubic

{packages.join(', ')}
</span>
)}
{dataFiles?.length && (
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Same rendering bug: dataFiles?.length && (...) will render a literal 0 when dataFiles is an empty array. Use !!dataFiles?.length or a ternary.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx, line 80:

<comment>Same rendering bug: `dataFiles?.length && (...)` will render a literal `0` when `dataFiles` is an empty array. Use `!!dataFiles?.length` or a ternary.</comment>

<file context>
@@ -0,0 +1,124 @@
+									{packages.join(', ')}
+								</span>
+							)}
+							{dataFiles?.length && (
+								<span className='flex items-center gap-1'>
+									<Database size={10} />
</file context>
Fix with Cubic

<div className='overflow-auto max-h-80'>
{(packages?.length || dataFiles?.length) && (
<div className='flex flex-wrap gap-2 px-3 py-2 border-b border-border text-xs text-foreground/60'>
{packages?.length && (
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Rendering bug: packages?.length && (...) will render a literal 0 in the DOM when packages is an empty array. Use a boolean coercion (!!packages?.length) or a ternary to avoid this.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/frontend/src/components/tool-calls/execute-sandboxed-code.tsx, line 74:

<comment>Rendering bug: `packages?.length && (...)` will render a literal `0` in the DOM when `packages` is an empty array. Use a boolean coercion (`!!packages?.length`) or a ternary to avoid this.</comment>

<file context>
@@ -0,0 +1,124 @@
+				<div className='overflow-auto max-h-80'>
+					{(packages?.length || dataFiles?.length) && (
+						<div className='flex flex-wrap gap-2 px-3 py-2 border-b border-border text-xs text-foreground/60'>
+							{packages?.length && (
+								<span className='flex items-center gap-1'>
+									<Package size={10} />
</file context>
Fix with Cubic

Allow the agent to use sandboxes to run code in a secure environment. Works with{' '}
<a
href='https://github.com/boxlite-ai/boxlite'
target='_blank'
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Missing rel='noopener noreferrer' on target='_blank' link. The existing codebase pattern (e.g., slack-config-section.tsx) consistently includes this attribute on external links for security hardening.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/frontend/src/components/settings/experimental.tsx, line 80:

<comment>Missing `rel='noopener noreferrer'` on `target='_blank'` link. The existing codebase pattern (e.g., `slack-config-section.tsx`) consistently includes this attribute on external links for security hardening.</comment>

<file context>
@@ -59,6 +69,31 @@ export function SettingsExperimental({ isAdmin }: SettingsExperimentalProps) {
+						Allow the agent to use sandboxes to run code in a secure environment. Works with{' '}
+						<a
+							href='https://github.com/boxlite-ai/boxlite'
+							target='_blank'
+							className='text-primary hover:text-primary/80 underline font-medium'
+						>
</file context>
Suggested change
target='_blank'
target='_blank'
rel='noopener noreferrer'
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant