Fix Ollama model resolution without API key

[ClaireGz]

Summary

• allow explicit Ollama model selections to resolve without requiring project config or OLLAMA_API_KEY
• treat OLLAMA_BASE_URL as sufficient to expose Ollama as an env-configured provider
• add backend tests covering Ollama resolution and env provider detection

Testing

• bun test apps/backend/tests/llm.utils.test.ts
• bun test apps/backend/tests/utils.test.ts

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/backend/src/utils/llm.ts">

<violation number="1" location="apps/backend/src/utils/llm.ts:26">
P2: The Ollama branch in `getEnvProviders()` replaces the `hasEnvApiKey` check entirely with `getEnvBaseUrl`, dropping support for configurations where only `OLLAMA_API_KEY` is set (without `OLLAMA_BASE_URL`). The condition should accept either signal.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: The Ollama branch in getEnvProviders() replaces the hasEnvApiKey check entirely with getEnvBaseUrl, dropping support for configurations where only OLLAMA_API_KEY is set (without OLLAMA_BASE_URL). The condition should accept either signal.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/src/utils/llm.ts, line 26:

<comment>The Ollama branch in `getEnvProviders()` replaces the `hasEnvApiKey` check entirely with `getEnvBaseUrl`, dropping support for configurations where only `OLLAMA_API_KEY` is set (without `OLLAMA_BASE_URL`). The condition should accept either signal.</comment>

<file context>
@@ -22,7 +22,12 @@ export function hasEnvApiKey(provider: LlmProvider): boolean {
 export function getEnvProviders(): LlmProvider[] {
-	return (Object.keys(LLM_PROVIDERS) as LlmProvider[]).filter(hasEnvApiKey);
+	return (Object.keys(LLM_PROVIDERS) as LlmProvider[]).filter((provider) => {
+		if (provider === 'ollama') {
+			return !!getEnvBaseUrl(provider);
+		}
</file context>

Suggested change

	if (provider === 'ollama') {
	return !!getEnvBaseUrl(provider);
	if (provider === 'ollama') {
	return !!getEnvBaseUrl(provider) || hasEnvApiKey(provider);

[Bl3f]

@socallmebertille why do we need to do this? didn't we already support this in your PR #267?

[socallmebertille]

Indeed @Bl3f , #267 covered it !

[MatLBS]

Ok so we can close this PR?