fix(runtime): Preserve daemon next-step params in CLI hints#259
Open
cameroncooke wants to merge 3 commits intomainfrom
Open
fix(runtime): Preserve daemon next-step params in CLI hints#259cameroncooke wants to merge 3 commits intomainfrom
cameroncooke wants to merge 3 commits intomainfrom
Conversation
cameroncooke
force-pushed
the
XcodeBuildMCP-build-run-device
branch
from
e2490e9 to
4a9f845
Compare
Introduce a first-class device build-and-run flow that builds, installs, and launches in one step for physical devices. Add shared build-settings and bundle-id helpers to keep app path and bundle resolution consistent across device and discovery tools, and update manifests, CLI docs, tests, and smoke coverage for the new command surface.
Skip manifest template re-application for daemon-routed responses. Daemon-invoked tools are already post-processed before returning to CLI. A second template merge in CLI could overwrite concrete dynamic params such as logSessionId, producing incomplete follow-up command hints.
cameroncooke
force-pushed
the
XcodeBuildMCP-build-run-device
branch
from
4a9f845 to
ef833ed
Compare
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
..._projects/iOS_Calculator/CalculatorAppPackage/Sources/CalculatorAppFeature/ContentView.swift
Show resolved
Hide resolved
Extract device platform string-to-enum mapping into a shared helper used by build_run_device and get_device_app_path. This removes duplicated mapping logic while preserving existing behavior and keeps device tool platform handling consistent in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add first-class physical-device build-and-run support and align next-step behavior across CLI/daemon flows.
This PR introduces the new
device build-and-runtool end-to-end (manifest wiring, implementation, tests, and smoke coverage) so users can build, install, and launch on real devices in one command. It also extracts shared app metadata/build-settings helpers used by device flows (build-settingsresolution and bundle ID extraction), and updates related device/simulator tool paths and docs to reflect the expanded workflow.While validating device log-capture flows, we found a runtime inconsistency: daemon-routed responses could lose dynamic next-step values when CLI post-processing reapplied templates. This PR fixes that by preserving daemon-provided next-step params while keeping direct invocation template behavior unchanged.
Alternative considered: disable template application globally. I did not take that path because it would regress direct invocation behavior and existing manifest-driven next steps. The implemented change narrows behavior only where daemon responses have already been post-processed.
Additional context for review: