Skip to content

fix(docs): remove double borders and fix column alignment on landing page tables #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
betegon merged 1 commit into from
Mar 6, 2026
Merged

fix(docs): remove double borders and fix column alignment on landing page tables #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ const base = process.env.DOCS_BASE_PATH || "/";
export default defineConfig({
site: "https://cli.sentry.dev",
base,
markdown: {
smartypants: false,
},
integrations: [
sentry({
project: "cli-website",
Expand Down
30 changes: 28 additions & 2 deletions docs/src/styles/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ starlight-tabs [role="tabpanel"] {
Code Blocks
========================================================================== */

pre:not(.pm-pre) {
pre:not(.pm-pre):not(.table-box) {
background: rgba(20, 20, 25, 0.9) !important;
border: 1px solid rgba(255, 255, 255, 0.08) !important;
border-radius: 12px !important;
Expand All @@ -929,6 +929,32 @@ pre.pm-pre,
padding: 0 !important;
}

/* ASCII art tables inside terminals - no chrome, consistent monospace */
pre.table-box {
background: transparent !important;
border: none !important;
border-radius: 0 !important;
margin: 0 !important;
padding: 0 !important;
}

pre.table-box,
pre.table-box * {
font-family: ui-monospace, 'Cascadia Code', 'Source Code Pro', Menlo, Consolas, 'DejaVu Sans Mono', monospace !important;
font-size: inherit !important;
Copy link

@cursor cursor bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wildcard !important overrides intentional table font-size 0.7rem

Medium Severity

The pre.table-box and pre.table-box * rules set font-size: inherit !important, overriding the intentional font-size: 0.7rem defined for .table-box and .header-text in both Terminal.astro and FeatureTerminal.astro. The table text will inherit the parent's larger font-size (e.g., 0.8rem from .terminal-body), making the ASCII art tables bigger than designed, which could itself break the column alignment this PR aims to fix.

Fix in Cursor Fix in Web

font-weight: 400 !important;
font-style: normal !important;
font-variant: normal !important;
font-variant-ligatures: none !important;
font-feature-settings: normal !important;
font-stretch: normal !important;
letter-spacing: 0 !important;
word-spacing: 0 !important;
text-decoration: none !important;
text-transform: none !important;
-webkit-text-size-adjust: none !important;
}
Copy link

@cursor cursor bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wildcard !important overrides alias-hl bold and underline styling

Medium Severity

The pre.table-box * rule sets font-weight: 400 !important and text-decoration: none !important, which overrides the .alias-hl class styling (font-weight: 700 and text-decoration: underline) defined in both Terminal.astro and FeatureTerminal.astro. Since .alias-hl spans are children of pre.table-box, the wildcard selector matches them and the !important wins, silently removing the bold+underline highlighting on alias characters in the tables.

Additional Locations (1)

Fix in Cursor Fix in Web


code {
font-family: var(--sl-font-mono);
font-size: 0.9em;
Expand Down Expand Up @@ -1089,7 +1115,7 @@ code {
}

/* Standalone pre */
.sl-markdown-content pre:not(.expressive-code pre):not(.pm-pre) {
.sl-markdown-content pre:not(.expressive-code pre):not(.pm-pre):not(.table-box) {
background: #0a0a0f !important;
border: 1px solid rgba(255, 255, 255, 0.1) !important;
border-radius: 12px !important;
Expand Down