Skip to content

fix(trace): show span IDs in trace view and fix event_id mapping#400

Merged
betegon merged 4 commits intomainfrom
fix/trace-view-span-ids
Mar 13, 2026
Merged

fix(trace): show span IDs in trace view and fix event_id mapping#400
betegon merged 4 commits intomainfrom
fix/trace-view-span-ids

Conversation

@betegon
Copy link
Member

@betegon betegon commented Mar 12, 2026

Summary

trace view showed undefined for every span ID in the tree because the trace detail API returns event_id instead of span_id. This also broke span view lookups since findSpanById compared against the missing field.

Two fixes:

  • Normalize the API response in getDetailedTrace by copying event_idspan_id when span_id is missing
  • Append the span ID (dimmed) to each span tree line so users can copy it into span view

Before:

├─ http.client — GET /api/users  (52ms)  undefined

After:

├─ http.client — GET /api/users  (52ms)  a6ff0caaa87dd118

Test plan

  • bun run typecheck passes
  • bun run lint passes
  • bun test test/lib/formatters/span-tree.test.ts — 20 tests pass
  • Manual: trace view <trace-id> shows real span IDs
  • Manual: span view <span-id> --trace <trace-id> finds the span

🤖 Generated with Claude Code

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Init

  • Add --team flag to relay team selection to project creation by MathurAditya724 in #403
  • Enforce canonical feature display order by betegon in #388
  • Accept multiple delimiter formats for --features flag by betegon in #386
  • Add git safety checks before wizard modifies files by betegon in #379
  • Add experimental warning before wizard runs by betegon in #378
  • Add init command for guided Sentry project setup by betegon in #283

Issue List

  • Auto-compact when table exceeds terminal height by BYK in #395
  • Redesign table to match Sentry web UI by BYK in #372

Other

  • (auth) Allow re-authentication without manual logout by BYK in #417
  • (trial) Auto-prompt for Seer trial + sentry trial list/start commands by BYK in #399
  • Support SENTRY_HOST as alias for SENTRY_URL by betegon in #409
  • Add --dry-run flag to mutating commands by BYK in #387
  • Return-based output with OutputConfig on buildCommand by BYK in #380
  • Add --fields flag for context-window-friendly JSON output by BYK in #373
  • Magic @ selectors (@latest, @most_frequent) for issue commands by BYK in #371
  • Input hardening against agent hallucinations by BYK in #370
  • Add response caching for read-only API calls by BYK in #330

Bug Fixes 🐛

Dsn

Init

  • Make URLs clickable with OSC 8 terminal hyperlinks by MathurAditya724 in #423
  • Remove implementation detail from help text by betegon in #385
  • Truncate uncommitted file list to first 5 entries by MathurAditya724 in #381

Other

  • (api) Convert --data to query params for GET requests by BYK in #383
  • (docs) Remove double borders and fix column alignment on landing page tables by betegon in #369
  • (trace) Show span IDs in trace view and fix event_id mapping by betegon in #400
  • Show human-friendly names in trial list and surface plan trials by BYK in #412
  • Add trace ID validation to trace view + UUID dash-stripping by BYK in #375

Documentation 📚

  • Update credential storage docs and remove stale config.json references by betegon in #408

Internal Changes 🔧

Init

  • Remove --force flag by betegon in #377
  • Remove dead determine-pm step label by betegon in #374

Tests

  • Consolidate unit tests subsumed by property tests by BYK in #422
  • Remove redundant and low-value tests by BYK in #418

Other

  • (log/list) Convert non-follow paths to return CommandOutput by BYK in #410
  • Convert list command handlers to return data instead of writing stdout by BYK in #404
  • Split api-client.ts into focused domain modules by BYK in #405
  • Migrate non-streaming commands to CommandOutput with markdown rendering by BYK in #398
  • Convert Tier 2-3 commands to return-based output and consola by BYK in #394
  • Convert remaining Tier 1 commands to return-based output by BYK in #382
  • Converge Tier 1 commands to writeOutput helper by BYK in #376

Other

  • Minify JSON on read and pretty-print on write in init local ops by MathurAditya724 in #396

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Codecov Results 📊

111 passed | Total: 111 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 1065 uncovered lines.
✅ Project coverage is 95.03%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
human.ts 96.40% ⚠️ 44 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    95.03%    95.03%        —%
==========================================
  Files          159       159         —
  Lines        21431     21441       +10
  Branches         0         0         —
==========================================
+ Hits         20366     20376       +10
- Misses        1065      1065         —
- Partials         0         0         —

Generated by Codecov Action

The trace detail API returns `event_id` instead of `span_id` on each
span, so all span IDs rendered as `undefined` in the span tree and
`span view` lookups always failed. Normalize the response in
`getDetailedTrace` by copying `event_id` → `span_id`, and append the
span ID to each tree line so users can copy it into `span view`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@betegon betegon force-pushed the fix/trace-view-span-ids branch from 6dd9fc1 to d1c32a9 Compare March 12, 2026 07:55
@betegon betegon marked this pull request as ready for review March 12, 2026 09:09
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

betegon and others added 3 commits March 12, 2026 10:39
Prevent rendering literal "undefined" when both span_id and event_id
are absent on a span.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Export the function and add unit tests covering event_id→span_id
fallback, existing span_id preservation, and child recursion.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflict from api-client split (#405). Move normalizeTraceSpan
and the getDetailedTrace normalization call into src/lib/api/traces.ts.
Rename test file to kebab-case to satisfy lint.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@betegon betegon merged commit 224e6dc into main Mar 13, 2026
22 checks passed
@betegon betegon deleted the fix/trace-view-span-ids branch March 13, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant