Skip to content

Conversation

@supervacuus
Copy link
Collaborator

@supervacuus supervacuus commented Nov 13, 2025

related parent PR: getsentry/sentry-native#1446

@supervacuus
Copy link
Collaborator Author

Uhm, just to be clear: this is a false positive. Yes, in theory this is only non-trivially copyable but those unions only contain POD. There is nothing inside that would bypass correct initialization with a memset. Ideally, upstream would do modern value initialization on one of the union tags in that ctor-list. But in the name of upstream maintainability I think disabling the false positive in the util build-script is the best choice.

@supervacuus supervacuus merged commit 60dd899 into getsentry Nov 14, 2025
17 checks passed
@supervacuus supervacuus deleted the fix/silence-nontrivial-memcall branch November 14, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants