Skip to content

added downtime minutes and availability view#114

Open
ghengiskhanh wants to merge 26 commits intomainfrom
khanh/downtime-minutes-v2
Open

added downtime minutes and availability view#114
ghengiskhanh wants to merge 26 commits intomainfrom
khanh/downtime-minutes-v2

Conversation

@ghengiskhanh
Copy link
Member

No description provided.

@ghengiskhanh ghengiskhanh requested a review from a team as a code owner February 27, 2026 18:44
}
.bg-avail-bad {
background-color: #6b1a12;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Availability cell text unreadable in light mode

High Severity

The bg-avail-good (#1e6b28), bg-avail-warn (#6b4d0a), and bg-avail-bad (#6b1a12) classes use hardcoded dark background colors that don't vary by theme. In light mode, text-content-headings resolves to near-black (rgb(24, 18, 37)) and text-content-secondary to medium-dark gray, producing near-zero contrast against these dark backgrounds. Availability percentages, downtime text, and incident links become effectively invisible for light mode users.

Additional Locations (2)

Fix in Cursor Fix in Web

Replaces Khanh's table-based availability UI with card-based heatmap
bars per region. Each heatmap block links to the incident list with
filters pre-applied (region, time range, service tier, status). Also
adds Roboto Mono font and moderate-intensity color utilities for the
heatmap.
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

{label}
</Link>
);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PeriodTab component is unused dead code

Low Severity

PeriodTab.tsx exports PeriodTab but it's never imported anywhere in the codebase. It also duplicates the rendering logic already implemented inline within PeriodTabs.tsx, which is the component actually used by the availability page. This was flagged in the PR discussion as well ("why do we need this defined twice?").

Fix in Cursor Fix in Web

</div>
</div>
);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RegionTable component is unused dead code

Low Severity

RegionTable.tsx exports RegionTable but it's never imported anywhere in the codebase. This is a 157-line component with its own state management, sorting logic, and a duplicated availabilityBgClass threshold function (mirroring getAvailabilityLevel in utils.ts). The availability page only uses RegionCard, not RegionTable.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants