Add 12 minute timeout limit to overall kafka process #460
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoHinderling
force-pushed
the
add-timeout-to-macho-parsing
branch
from
3022441 to
b7bf3c3
Compare
NicoHinderling
force-pushed
the
add-timeout-to-macho-parsing
branch
from
b7bf3c3 to
e0e703e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 80.26% 80.21% -0.06%
==========================================
Files 159 159
Lines 13482 13492 +10
Branches 1428 1429 +1
==========================================
+ Hits 10822 10823 +1
- Misses 2122 2131 +9
Partials 538 538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trevor-e
approved these changes
Nov 5, 2025
| """ | ||
| start_time = time.time() | ||
|
|
||
| if hasattr(signal, "SIGALRM"): |
| raise | ||
| finally: | ||
| # Cancel the timeout alarm as it's an expected exit | ||
| if hasattr(signal, "SIGALRM"): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a situation where parsing a binary actually hung and the whole parent process then hung as a result. We didn't have a timeout for the parent process so it just hung indefinitely. With this change our parent process will timeout after 12 minutes and the kafka message will be completed