feat(server): Improve error handling during shutdown #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Oct 31, 2025
Comment on lines
+116
to
+117
| let guard = if graceful_shutdown { | ||
| Some(elegant_departure::get_shutdown_guard()) |
There was a problem hiding this comment.
just noticing now that you made this configurable recently.
why would you ever not want to enable this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the sequence of operation during shutdown: Upon receiving the shutdown
signal, we immediately print a message on stdout. Next, we wait for the server
future to complete and log any errors. This ensures the error is tracked in
Sentry, whereas before we returned it from
main. Only once that is done, weflush metrics.