ref(service): Use JSON to encode metadata #165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode metadata using JSON instead of bincode. This fixes two issues:
risking to break past consumers.
metadata, we can do so now. Bincode will fail when using
skipon fields.The implementation on LocalFs is not the most efficient one, since it allocates
a string for metdata. However, since our metadata tends to be fairly small and
we will place strict limits on the maximum number and size of custom fields,
this is OK.
This is a one-time breaking change.
Fixes FS-178