fix: Add explicit permissions to workflow files#7121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissionsblocks to the 3 workflows flagged byCodeQL for
actions/missing-workflow-permissions(alerts feat(issues): Add trigger for 'accepted' issues #2, deploy: sentry@20.12.0 #5, deploy: relay@2.0.1 #6).test.yml:contents: read(only checks out code and runs tests)publish.yml:contents: read+issues: write(checkout + issuecomments/labels/close via
GITHUB_TOKEN; cross-repo ops use the ReleaseBot app token)
auto-approve.yml:contents: read(needed for the sparse checkoutbeing added in refactor: Extract auto-approve repo list into a text file #7119; currently no
GITHUB_TOKENwrite usage)Resolves all 3 open code-scanning alerts.