Skip to content

ref: Remove unused requester field from parsed inputs #7169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Feb 13, 2026
Merged

ref: Remove unused requester field from parsed inputs #7169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/modules/__tests__/details-from-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ test("parse inputs", async () => {
merge_target: "custom-branch",
path: ".",
repo: "sentry",
requester: "BYK",
targets: ["github", "npm[@sentry/node]", "docker[latest]"],
version: "21.3.1",
});
Expand Down Expand Up @@ -97,7 +96,6 @@ test("Do not extract merge_target value if its a default value", async () => {
merge_target: "",
path: ".",
repo: "sentry",
requester: "BYK",
targets: ["github", "docker[latest]"],
version: "21.3.1",
});
Expand Down
23 changes: 8 additions & 15 deletions src/modules/details-from-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/**
* Matches the entire "Targets" section of a github publish issue body.
*/
const TARGETS_SECTION_PARSER_REGEX = /^(?!### Targets$\s)(?: *- \[[ xX]\] \S+\s*$(?:\r?\n)?)+/m;
const TARGETS_SECTION_PARSER_REGEX =
/^(?!### Targets$\s)(?: *- \[[ xX]\] \S+\s*$(?:\r?\n)?)+/m;

/**
* Matches all targets of a github publish issue body in a section that was already matched and extracted with `TARGETS_PARSER_REGEX`.
Expand All @@ -15,28 +16,19 @@ const TARGETS_PARSER_REGEX = /^\s*- \[[ x]\] (\S+)/gim;
*/
const CHECKED_TARGETS_PARSER_REGEX = /^\s*- \[x\] (\S+)/gim;


async function detailsFromContext({ context }) {
if (!context || !context.payload || !context.payload.issue) {
throw new Error('Issue context is not defined');
throw new Error("Issue context is not defined");
}

const titleParser = /^publish: (?:getsentry\/)?(?<repo>[^/@]+)(?<path>\/[\w./-]+)?@(?<version>[\w.+-]+)$/;
const titleParser =
/^publish: (?:getsentry\/)?(?<repo>[^/@]+)(?<path>\/[\w./-]+)?@(?<version>[\w.+-]+)$/;
const titleMatch = context.payload.issue.title.match(titleParser).groups;
const dry_run = context.payload.issue.labels.some((l) => l.name === "dry-run")
? "1"
: "";
const path = "." + (titleMatch.path || "");

// - May only contain alphanumeric characters and hyphens.
// - Cannot have multiple consecutive hyphens.
// - Cannot begin or end with a hyphen.
// - Maximum 39 characters.
const requesterParser = /^Requested by: @(?<requester>[a-zA-Z\d](?:[a-zA-Z\d]|-(?=[a-zA-Z\d])){0,38})$/m;
const { requester } = context.payload.issue.body.match(
requesterParser
).groups;

// https://docs.github.com/en/get-started/using-git/dealing-with-special-characters-in-branch-and-tag-names#naming-branches-and-tags
const mergeTargetParser = /^Merge target: (?<merge_target>[\w.\-/]+)$/m;
const mergeTargetMatch = context.payload.issue.body.match(mergeTargetParser);
Expand All @@ -45,7 +37,9 @@ async function detailsFromContext({ context }) {
merge_target = mergeTargetMatch.groups.merge_target || "";
}

const targetsMatch = context.payload.issue.body.match(TARGETS_SECTION_PARSER_REGEX);
const targetsMatch = context.payload.issue.body.match(
TARGETS_SECTION_PARSER_REGEX
);
let targets;
if (targetsMatch) {
targets = Array.from(
Expand All @@ -58,7 +52,6 @@ async function detailsFromContext({ context }) {
dry_run,
merge_target,
path,
requester,
targets,
};
}
Expand Down