Skip to content

ref(build): release Docker image to GHCR via Craft #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldy505 wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −34
Open

ref(build): release Docker image to GHCR via Craft #5509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04aa742
build: release Docker image to GHCR via Craft
aldy505 Dec 24, 2025
565a914
build: wrong repository name
aldy505 Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
minVersion: 0.23.1
changelogPolicy: auto
minVersion: "2.15.0"
changelog:
policy: auto

statusProvider:
name: github
config:
contexts:
- "Build Docker Image (relay)"
Comment on lines +5 to +9
Copy link

@sentry sentry bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The .craft.yml configuration waits for a GitHub status check "Build Docker Image (relay)", but the workflow providing it is being removed, causing a release deadlock.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The .craft.yml file is configured with a statusProvider that waits for a GitHub status check named "Build Docker Image (relay)". However, the pull request removes the .github/workflows/release-ghcr-version-tag.yml workflow, which was the likely source for this status check. No other workflow in the repository is configured to produce a check with this specific name. As a result, the Craft release process will hang indefinitely or time out while waiting for a status check that will never be created, effectively blocking all releases.

💡 Suggested Fix

Update the statusProvider configuration in .craft.yml to wait for a status check that is produced by an existing workflow, or modify an existing workflow to produce the required "Build Docker Image (relay)" status check.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .craft.yml#L5-L9

Potential issue: The `.craft.yml` file is configured with a `statusProvider` that waits
for a GitHub status check named `"Build Docker Image (relay)"`. However, the pull
request removes the `.github/workflows/release-ghcr-version-tag.yml` workflow, which was
the likely source for this status check. No other workflow in the repository is
configured to produce a check with this specific name. As a result, the Craft release
process will hang indefinitely or time out while waiting for a status check that will
never be created, effectively blocking all releases.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7908621

Copy link
Member

@BYK BYK Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldy505 this looks legit?

Copy link
Collaborator Author

@aldy505 aldy505 Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. "Build Docker Image" is defined on ci.yml here https://github.com/aldy505/sentry-relay/blob/565a914c7944c5409fdd5c7e445ee275d7a75a30/.github/workflows/ci.yml#L492


targets:
- name: github
Expand All @@ -20,12 +27,12 @@ targets:
cacheControl: public, max-age=600
- id: release
name: docker
source: us-central1-docker.pkg.dev/sentryio/relay/relay
target: getsentry/relay
source: ghcr.io/getsentry/relay
target: ghcr.io/getsentry/relay
- id: latest
name: docker
source: us-central1-docker.pkg.dev/sentryio/relay/relay
target: getsentry/relay
source: ghcr.io/getsentry/relay
target: ghcr.io/getsentry/relay
targetFormat: "{{{target}}}:latest"

requireNames:
Expand Down
28 changes: 0 additions & 28 deletions .github/workflows/release-ghcr-version-tag.yml
View file
Open in desktop

This file was deleted.

Loading