docs: Redirect from old /generated pages to new routes#291
Open
docs: Redirect from old /generated pages to new routes#291
/generated pages to new routes#291Conversation
Lms24
requested review from
a team,
cleptric,
lcian,
mjq and
nsdeschenes
as code owners
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we moved the Sentry Conventions docs page from Markdown to Astro, the URLs changed slightly. This is a bit unfortunate but I'd argue the new ones make a bit more sense. However, to avoid links (e.g. in code) leading to 404 pages, this PR adds a "client-side redirect" strategy to redirect anything from a previously
/sentry-conventions/generated/*path to/sentry-conventions/*. SEO-wise this isn't ideal but since we host on GH pages, we can't define server-side redirects. We don't really care about SEO though since this is primarily an internal website, so I think it's a fine tradeoff.