-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(attributes): Add app context attributes for mobile #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
buenaflor
wants to merge
8
commits into
main
Choose a base branch
from
buenaflor/feat/add-app-context-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aff2122
feat(attributes): Add `app.*` attributes for mobile app context
buenaflor 1360e8b
ref(attributes): Drop app.version, app.identifier, app.build
buenaflor d554af4
ref(attributes): Drop app.name
buenaflor 04c04a4
feat(attributes): Re-add app.name, app.version, app.identifier, app.b…
buenaflor a70ee75
fix(attributes): Set app.in_foreground pii to false
buenaflor efd0eb8
fix(attributes): Set pii to false for non-PII app attributes
buenaflor 8126f65
chore(attributes): Add PR number to app attribute changelog entries
buenaflor 42badff
fix(attributes): Align app attribute pii values with conventions
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.build", | ||
| "brief": "Internal build identifier, as it appears on the platform.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": "1", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [296], | ||
| "description": "Added app.build attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.identifier", | ||
| "brief": "Version-independent application identifier, often a dotted bundle ID.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": "com.example.myapp", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [296], | ||
| "description": "Added app.identifier attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.in_foreground", | ||
| "brief": "Whether the application is currently in the foreground.", | ||
| "type": "boolean", | ||
| "pii": { | ||
| "key": "false" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": true, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [296], | ||
| "description": "Added app.in_foreground attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.name", | ||
| "brief": "Human readable application name, as it appears on the platform.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": "My App", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [296], | ||
| "description": "Added app.name attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.start_time", | ||
| "brief": "Formatted UTC timestamp when the user started the application.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": "2025-01-01T00:00:00.000Z", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [296], | ||
| "description": "Added app.start_time attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.version", | ||
| "brief": "Human readable application version, as it appears on the platform.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": "1.0.0", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [296], | ||
| "description": "Added app.version attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.