Document global attributes #15279
Draft
Document global attributes #15279
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
AbhiPrasad
reviewed
Oct 29, 2025
Comment on lines
+70
to
+73
| "app.feature_flag.enabled": { | ||
| type: "boolean", | ||
| value: true | ||
| }, |
There was a problem hiding this comment.
IMO we should allow for an API that allows for the SDK to infer the type for the user. Otherwise this becomes more annoying for the dynamic language sdks.
The attributes API currently in logs doesn't allow for users to specify the type.
|
|
||
| Attributes are key-value pairs where each value is an object containing: | ||
|
|
||
| - `type`: The data type (`"string"`, `"integer"`, `"double"`, or `"boolean"`) |
There was a problem hiding this comment.
I think we can be less strict here. If we allow for more types, we can cast complex types to string and still allow them to be set. I think this makes it an easier API for users to use, and feels very easy to transition from contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.