feat(ndk): handle native init failure code #4842
Open
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
For initializing the android ndk we call via JNI into our
sentry.ccode, which returns aintfor success or failure.Right now the result of this init call is not checked.
💡 Motivation and Context
I have the hunch that in one of our clients app's the ndk sdk fails to properly initialize. Due to not propagating the result code up to java we don't throw if there have been an error during setup.
This PR can only though once this is merged in
getsentry/native:💚 How did you test it?
I'll be honest, i didn't as this seemed like a straight forward change 😅
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps