fix(craft): Add missing mainDocsUrl for @sentry/effect SDK#19860
fix(craft): Add missing mainDocsUrl for @sentry/effect SDK#19860
Conversation
The Effect SDK was missing the mainDocsUrl field in the craft configuration, causing KeyError: 'main_docs_url' in Sentry backend (SENTRY-5M6R). This adds the documentation URL following the same pattern as other JavaScript SDKs in the registry. Fixes SENTRY-5M6R
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for opening this PR Since when is this required? None of the other packages define this property.
|
We might need to fix this in the release registry directly since we already made the first release. |
I was thinking we would do a re-release, but maybe that's not the right thing to do because this release is broken. Do you know how to fix it directlyi? |
size-limit report 📦
|
Claude says: The problem is that @sentry/effect explicitly defined custom fields (name, sdkName, packageUrl) but didn't include mainDocsUrl. This likely prevented Craft from using its default URL generation logic. When an SDK entry has custom fields, it seems Craft expects you to provide ALL the necessary fields, including So mainDocsUrl is required when:
|
|
Would a new release of Also I feel like craft should have caught this before, I think this needs to be improved - I could follow up on this |
|
let's not merge this please |
Yes, it would be good for it to verify the required properties. cc'ing Mr. Craft @BYK |
|
I'll close this in favor of getsentry/sentry-release-registry#229 |
|
After thinking over it. Reopening since we still have to have it actually |
|
Yeah let's wait with closing this until we properly investigate things tomorrow. If the outcome is that this needs to be set by SDKs now, it would be a fairly drastic change. So I'd prefer it if we can somehow infer this in craft. |
|
Read the docs please: https://craft.sentry.dev/targets/registry/#creating-new-packages :) |
5 participants
Problem
The @sentry/effect SDK was added to the release registry without the required
mainDocsUrlfield in the craft configuration. This causes a KeyError in the Sentry backend when trying to access SDK documentation URLs.Sentry Issue: SENTRY-5M6R
KeyError: 'main_docs_url'Solution
This PR adds the missing
mainDocsUrlfield to the Effect SDK configuration in.craft.yml, following the same pattern as other JavaScript SDKs.Changes
mainDocsUrl: 'https://docs.sentry.io/platforms/javascript/guides/effect/'to the Effect SDK registry configurationTesting
Impact
Fixes SENTRY-5M6R