fix(cloudflare): Forward ctx argument to Workflow.do user callback#19891
fix(cloudflare): Forward ctx argument to Workflow.do user callback#19891
ctx argument to Workflow.do user callback#19891Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. A reminder to ourselves that this could happen anytime. It might make sense to always just forward all callback arguments in Cloudflare when there is something like that to be future proof.
size-limit report 📦
|
Agreed! I had Cursor go over the cloudflare SDK and look for similar occurances but we usually pass all args. Worth noting that we use Based on the analysis, this was the only occurance where we didn't pass in arguments. We can follow up with a better audit but for now I think we're good. |
This PR fixes a bug in our Cloudflare Workflows instrumentation where we didn't forward the recently introduced
ctxargument to users'Workflow.docallbacks. We now pass all...argsfrom the workflow through our instrumentation to the user callback.closes #19883