fix(core): Do not overwrite user provided conversation id in Vercel#19903
fix(core): Do not overwrite user provided conversation id in Vercel#19903nicohrubec merged 5 commits intodevelopfrom
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Bug Fixes 🐛Core
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
left a comment
There was a problem hiding this comment.
The change LGTM but I agree with bugbot that we should harden the test.
L: Not sure if this is a me-Problem but I had a hard time understanding the PR title. IIUC this fix ensures we don't overwrite a user-provided (custom) conversationId. Maybe we can change the title to something like "do not overwrite user-provided conversation id"? Just a suggestion, feel free to disregard
|
The change itself looks fine to me, but improving the test sounds good 👍 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
@Lms24 thanks for the suggestions I updated the test to be more strict and I agree that your proposed PR title should be a bit more clear so I changed it as well |

We set the conversation id unconditionally based on the
resonse_id, so if a user callsSentry.setConversationId()explicitly this will still be overwritten, which is unexpected.Closes #19904 (added automatically)