feat(expo): Add RNSentrySDK APIs support to @sentry/react-native/expo plugin #4633

antonis · 2025-03-07T11:25:00Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Based on feat: Capture app start errors before JS

📜 Description

Adds RNSentrySDK APIs support to @sentry/react-native/expo plugin by importing sentry and adding injecting RNSentrySDK.init/start in the Android MainApplication (Kotlin or Java) or AppDelegate (Objective-C or Swift).

This feature is opt-out to enable it set useNativeInit to true in your @sentry/react-native/expo plugin configuration.

"plugins": [
  [
    "@sentry/react-native/expo",
    {
      "useNativeInit": true
    }
  ],

💡 Motivation and Context

Fixes #4625

💚 How did you test it?

CI, Manual

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2025-03-07T11:25:30Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3885d70

github-actions · 2025-03-07T11:54:41Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1209.39 ms	1214.90 ms	5.51 ms
Size	2.63 MiB	3.78 MiB	1.15 MiB

github-actions · 2025-03-07T12:08:49Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1234.24 ms	1237.90 ms	3.65 ms
Size	3.19 MiB	4.35 MiB	1.17 MiB

github-actions · 2025-03-07T14:35:37Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	441.12 ms	451.55 ms	10.43 ms
Size	17.75 MiB	20.15 MiB	2.40 MiB

github-actions · 2025-03-07T14:49:20Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	351.04 ms	404.94 ms	53.90 ms
Size	7.15 MiB	8.42 MiB	1.27 MiB

CHANGELOG.md

packages/core/plugin/src/withSentryAndroid.ts

lucas-zimerman

Overall the PR looks good and thank you for the tests!
I still think we could fine tune a bit more the android part and after it we could get ready for merge

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

antonis · 2025-04-04T10:40:54Z

Note: The Build & Test / Type Check Typescript 3.8 (pull_request) failure should be fixed when we merge #4673 from main

CHANGELOG.md

packages/core/plugin/src/withSentryAndroid.ts

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

packages/core/plugin/src/withSentryIOS.ts

lucas-zimerman

I have re-checked the PR and overall, I only found a nit on a string. After fixing it and if @krystofwoldrich doesn't find anything else, LGTM!

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

packages/core/plugin/src/withSentryAndroid.ts

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

packages/core/plugin/src/withSentryAndroid.ts

packages/core/plugin/src/withSentryIOS.ts

krystofwoldrich · 2025-06-11T08:35:19Z

I'm currently updating the base branch with the latest main since there was quite a lot of development that was not synced to the feature branch.

antonis · 2025-06-11T08:39:11Z

I'm currently updating the base branch with the latest main since there was quite a lot of development that was not synced to the feature branch.

Thank you for the heads up @krystofwoldrich 🙇
I'll update this branch after that along with the review feedback.

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…getsentry/sentry-react-native into antonis/4625-expo-useNativeInit

krystofwoldrich

Thank you for the fixes. 🚀 It looks great!

krystofwoldrich · 2025-06-12T15:45:18Z

CHANGELOG.md


 ### Features

+- Add RNSentrySDK APIs support to @sentry/react-native/expo plugin ([#4633](https://github.com/getsentry/sentry-react-native/pull/4633))


Nit. It would be nice to include an example code snippet and a small summary of what will the flag do.

Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>

…iveInit

github-actions · 2025-10-15T16:08:11Z

CHANGELOG.md


 ### Features

+- Add RNSentrySDK APIs support to @sentry/react-native/expo plugin ([#4633](https://github.com/getsentry/sentry-react-native/pull/4633))


🚫 The changelog entry seems to be part of an already released section ## 6.15.1.
Consider moving the entry to the ## Unreleased section, please.

lucas-zimerman · 2025-10-15T16:08:16Z

@sentry review

seer-by-sentry · 2025-10-15T16:13:19Z

packages/core/plugin/src/withSentryAndroid.ts

+      config.modResults.contents = config.modResults.contents.replace(
+        /(super\.onCreate\(\)[;\n]*)([ \t]*)/,
+        `$1\n$2RNSentrySDK.init(this);\n$2`,
+      );


The regex pattern /(super\.onCreate\(\)[;\n]*)([ \t]*)/ may not handle all edge cases properly. For example, if there are multiple spaces or tabs before the next line, or if there are comments immediately after super.onCreate(), the insertion might not be placed correctly. Consider adding a test case for files with unusual formatting.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

seer-by-sentry · 2025-10-15T16:13:19Z

packages/core/plugin/src/withSentryIOS.ts

+        /(func application\([^)]*\) -> Bool \{)\s*\n(\s*)/s,
+        `$1\n$2RNSentrySDK.start()\n$2`,
+      );


The regex pattern /(func application\([^)]*\) -> Bool \{)\s*\n(\s*)/s may fail to match if the function signature is split across multiple lines or has different whitespace patterns. Consider making the pattern more robust to handle multi-line function signatures:

/(func application\([^)]*\)\s*->\s*Bool\s*\{)\s*\n(\s*)/s

_{Did we get this right? 👍 / 👎 to inform future reviews.}

seer-by-sentry · 2025-10-15T16:13:20Z

packages/core/plugin/src/withSentryIOS.ts

+      config.modResults.contents = config.modResults.contents.replace(
+        /(- \(BOOL\)application:[\s\S]*?didFinishLaunchingWithOptions:[\s\S]*?\{\n)(\s*)/s,
+        `$1$2[RNSentrySDK start];\n$2`,


The regex pattern /(- \(BOOL\)application:[\s\S]*?didFinishLaunchingWithOptions:[\s\S]*?\{\n)(\s*)/s is overly greedy and could potentially match unintended content if there are multiple methods with similar signatures. Consider making it more specific by including the method return or limiting the character classes:

/(- \(BOOL\)application:\(UIApplication \*\)\w+\s+didFinishLaunchingWithOptions:\(NSDictionary \*\)\w+\s*\{\n)(\s*)/s

_{Did we get this right? 👍 / 👎 to inform future reviews.}

seer-by-sentry · 2025-10-15T16:13:20Z

packages/core/test/expo-plugin/modifyAppDelegate.test.ts

+
+  it('should insert import statements only once in an Swift project', async () => {
+    config.modResults.contents =
+      'import UIKit\nimport RNSentrySDK\n\noverride func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool {';
+
+    const result = (await modifyAppDelegate(config)) as MockedExpoConfig;
+
+    const importCount = (result.modResults.contents.match(/import RNSentrySDK/g) || []).length;


The test name and logic are inconsistent. The test checks for 'import RNSentrySDK' but the actual implementation imports 'import RNSentry'. This test should verify the correct import statement.

The expected import should be import RNSentry not import RNSentrySDK.

Suggested change

it('should insert import statements only once in an Swift project', async () => {

config.modResults.contents =

'import UIKit\nimport RNSentrySDK\n\noverride func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool {';

const result = (await modifyAppDelegate(config)) as MockedExpoConfig;

const importCount = (result.modResults.contents.match(/import RNSentrySDK/g) || []).length;

it('should insert import statements only once in an Swift project', async () => {

config.modResults.contents =

'import UIKit\nimport RNSentry\n\noverride func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool {';

const result = (await modifyAppDelegate(config)) as MockedExpoConfig;

const importCount = (result.modResults.contents.match(/import RNSentry/g) || []).length;

expect(importCount).toBe(1);

});

_{Did we get this right? 👍 / 👎 to inform future reviews.}

seer-by-sentry · 2025-10-15T16:13:20Z

packages/core/plugin/src/withSentryAndroid.ts

+      if (config.modResults.contents === originalContents) {
+        warnOnce(`Failed to insert 'RNSentrySDK.init' in '${fileName}'.`);
+      } else if (!config.modResults.contents.includes('import io.sentry.react.RNSentrySDK;')) {
+        // Insert import statement after package declaration
+        config.modResults.contents = config.modResults.contents.replace(
+          /(package .*;\n\n?)/,
+          `$1import io.sentry.react.RNSentrySDK;\n`,
+        );
+      }
+    } else if (config.modResults.language === 'kt') {
+      // Add RNSentrySDK.init
+      const originalContents = config.modResults.contents;


When the regex replacement fails and the contents remain unchanged, only a warning is logged but the import statement might still be added in the else block. This could result in an orphaned import statement without the corresponding initialization call. Consider checking if the replacement was successful before adding the import statement.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

seer-by-sentry · 2025-10-15T16:13:20Z

packages/core/plugin/src/withSentryIOS.ts

+      );
+      if (config.modResults.contents === originalContents) {
+        warnOnce(`Failed to insert 'RNSentrySDK.start()' in '${fileName}'.`);
+      } else if (!config.modResults.contents.includes('import RNSentry')) {
+        // Insert import statement after UIKit import
+        config.modResults.contents = config.modResults.contents.replace(/(import UIKit\n)/, `$1import RNSentry\n`);
+      }


When the regex replacement fails and the contents remain unchanged, only a warning is logged but the import statement might still be added in the else block. This could result in an orphaned import statement without the corresponding initialization call. Consider checking if the replacement was successful before adding the import statement.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

useNativeInit Android implementation

313e844

Adds changelog

2e97acc

useNativeInit iOS implementation

6eedaae

antonis added 3 commits March 7, 2025 18:01

Fix indentation

9ae5475

Extend test cases with realistic data

566550e

Adds code sample in the changelog

770c9f4

antonis linked an issue Mar 7, 2025 that may be closed by this pull request

Add RNSentrySDK APIs support to @sentry/react-native/expo plugin #4625

Open

antonis marked this pull request as ready for review March 7, 2025 16:22

antonis requested review from krystofwoldrich and lucas-zimerman as code owners March 7, 2025 16:22

lucas-zimerman reviewed Apr 3, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lucas-zimerman reviewed Apr 3, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Outdated Show resolved Hide resolved

lucas-zimerman reviewed Apr 3, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Outdated Show resolved Hide resolved

lucas-zimerman reviewed Apr 3, 2025

View reviewed changes

antonis and others added 2 commits April 4, 2025 11:01

Fix CHANGELOG.md

f8b37b5

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

Warn if RESentySDK.init/start wasn't injected

d25db30

antonis requested a review from lucas-zimerman April 4, 2025 09:45

krystofwoldrich reviewed Apr 15, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Make useNativeInit opt-in

adc81a5

antonis requested a review from krystofwoldrich April 15, 2025 10:00

krystofwoldrich reviewed Apr 15, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Outdated Show resolved Hide resolved

krystofwoldrich reviewed Apr 15, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Outdated Show resolved Hide resolved

krystofwoldrich reviewed Apr 15, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Outdated Show resolved Hide resolved

Make Android failure warning more clear

8c2cd73

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis requested a review from krystofwoldrich April 16, 2025 08:34

lucas-zimerman reviewed Apr 23, 2025

View reviewed changes

packages/core/plugin/src/withSentryIOS.ts Outdated Show resolved Hide resolved

lucas-zimerman approved these changes Apr 23, 2025

View reviewed changes

Add missing quote

0b3423f

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

krystofwoldrich mentioned this pull request May 27, 2025

Native Initialization in a react native project using expo #4857

Closed

krystofwoldrich reviewed Jun 10, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Outdated Show resolved Hide resolved

Remove unneeded async

5c615fd

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich reviewed Jun 10, 2025

View reviewed changes

packages/core/plugin/src/withSentryAndroid.ts Show resolved Hide resolved

krystofwoldrich reviewed Jun 10, 2025

View reviewed changes

packages/core/plugin/src/withSentryIOS.ts Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jun 10, 2025

View reviewed changes

packages/core/plugin/src/withSentryIOS.ts Outdated Show resolved Hide resolved

antonis added 2 commits June 10, 2025 18:18

Set useNativeInit = false by default

c356288

dynamically fill white spaces

8e32556

krystofwoldrich reviewed Jun 10, 2025

View reviewed changes

packages/core/plugin/src/withSentryIOS.ts Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jun 10, 2025

View reviewed changes

packages/core/plugin/src/withSentryIOS.ts Outdated Show resolved Hide resolved

antonis and others added 4 commits June 11, 2025 13:23

Add unsupported language in warning message

a20984c

Add objcpp in detected languages

d1db4fa

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4625-expo-useNativeInit' of https://github.com/…

7c25c2c

…getsentry/sentry-react-native into antonis/4625-expo-useNativeInit

Update tests for objcpp

1918baf

krystofwoldrich force-pushed the capture-app-start-errors branch 3 times, most recently from 2363742 to 588ba6d Compare June 12, 2025 15:26

krystofwoldrich approved these changes Jun 12, 2025

View reviewed changes

krystofwoldrich reviewed Jun 12, 2025

View reviewed changes

krystofwoldrich and others added 2 commits June 16, 2025 12:46

ref(expo-plugin): Split utils to logger, version and utils (#4906)

b2a89f2

Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>

Merge branch 'capture-app-start-errors' into antonis/4625-expo-useNat…

3885d70

…iveInit

github-actions bot reviewed Oct 15, 2025

View reviewed changes

seer-by-sentry bot reviewed Oct 15, 2025

View reviewed changes


		### Features

		- Add RNSentrySDK APIs support to @sentry/react-native/expo plugin ([#4633](https://github.com/getsentry/sentry-react-native/pull/4633))

Uh oh!

Uh oh!

feat(expo): Add RNSentrySDK APIs support to @sentry/react-native/expo plugin #4633

Are you sure you want to change the base?

feat(expo): Add RNSentrySDK APIs support to @sentry/react-native/expo plugin #4633

Uh oh!

Conversation

antonis commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Uh oh!

github-actions bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

antonis commented Apr 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich commented Jun 11, 2025

Uh oh!

antonis commented Jun 11, 2025

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman commented Oct 15, 2025

Uh oh!

seer-by-sentry bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

seer-by-sentry bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

seer-by-sentry bot Oct 15, 2025

Choose a reason for hiding this comment

antonis commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading