Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Oct 2, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

refresh

📜 Description

replay stubs are binary files, and when changes happens we reviewers do not know what actually changed.
This PR aims to give alerts on what was changed, like if the content is identical and creation time was changed, or if actually files were changed.

💡 Motivation and Context

💚 How did you test it?

CI

reference screenshots for when the file had different code: #5235 (comment)

reference screenshot for when the files are equal but only the creation date has changed: #5235 (comment)

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 324.43 ms 330.44 ms 6.01 ms
Size 17.75 MiB 19.70 MiB 1.96 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
20d5eaa 377.62 ms 406.50 ms 28.88 ms
c08359e 421.87 ms 445.37 ms 23.50 ms
8490686+dirty 365.59 ms 400.24 ms 34.65 ms
c1573b3 400.85 ms 411.82 ms 10.97 ms
c4e097a 338.06 ms 439.36 ms 101.30 ms
07808fb+dirty 419.10 ms 419.08 ms -0.02 ms
49ef936+dirty 405.96 ms 417.22 ms 11.26 ms
a31630c+dirty 408.91 ms 416.80 ms 7.89 ms
459a438+dirty 417.09 ms 406.52 ms -10.57 ms
05bef0e+dirty 349.78 ms 334.04 ms -15.74 ms

App size

Revision Plain With Sentry Diff
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
c08359e 17.75 MiB 20.15 MiB 2.41 MiB
8490686+dirty 17.75 MiB 19.70 MiB 1.96 MiB
c1573b3 17.75 MiB 20.15 MiB 2.41 MiB
c4e097a 17.75 MiB 19.68 MiB 1.94 MiB
07808fb+dirty 17.75 MiB 19.70 MiB 1.95 MiB
49ef936+dirty 17.75 MiB 19.69 MiB 1.94 MiB
a31630c+dirty 17.75 MiB 19.68 MiB 1.94 MiB
459a438+dirty 17.75 MiB 19.70 MiB 1.95 MiB
05bef0e+dirty 17.75 MiB 19.70 MiB 1.95 MiB

Previous results on branch: lz/replay-stub-check

Startup times

Revision Plain With Sentry Diff
93d725f+dirty 376.02 ms 371.70 ms -4.32 ms
1fc635a 386.06 ms 408.76 ms 22.70 ms
26b64bd+dirty 385.24 ms 370.50 ms -14.74 ms
0904b5b+dirty 362.86 ms 364.67 ms 1.81 ms
1dd4cb6+dirty 386.85 ms 401.14 ms 14.29 ms

App size

Revision Plain With Sentry Diff
93d725f+dirty 17.75 MiB 19.70 MiB 1.95 MiB
1fc635a 17.75 MiB 19.70 MiB 1.95 MiB
26b64bd+dirty 17.75 MiB 19.69 MiB 1.94 MiB
0904b5b+dirty 17.75 MiB 19.70 MiB 1.96 MiB
1dd4cb6+dirty 17.75 MiB 19.70 MiB 1.95 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 314.08 ms 335.32 ms 21.24 ms
Size 7.15 MiB 8.46 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f234eb4+dirty 313.23 ms 333.31 ms 20.08 ms
5c16cdc+dirty 375.45 ms 426.62 ms 51.17 ms
c4e097a+dirty 382.43 ms 443.77 ms 61.34 ms
c08359e+dirty 406.04 ms 428.87 ms 22.83 ms
785ffb1+dirty 380.65 ms 451.83 ms 71.18 ms
8ece263+dirty 369.44 ms 414.65 ms 45.21 ms
c9e95bd+dirty 339.32 ms 401.24 ms 61.92 ms
276d348+dirty 356.30 ms 405.27 ms 48.97 ms
49ef936+dirty 333.72 ms 387.51 ms 53.79 ms
2b89ce9+dirty 372.22 ms 417.06 ms 44.84 ms

App size

Revision Plain With Sentry Diff
f234eb4+dirty 7.15 MiB 8.46 MiB 1.30 MiB
5c16cdc+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c4e097a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c08359e+dirty 7.15 MiB 8.42 MiB 1.27 MiB
785ffb1+dirty 7.15 MiB 8.42 MiB 1.27 MiB
8ece263+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c9e95bd+dirty 7.15 MiB 8.41 MiB 1.26 MiB
276d348+dirty 7.15 MiB 8.42 MiB 1.26 MiB
49ef936+dirty 7.15 MiB 8.42 MiB 1.26 MiB
2b89ce9+dirty 7.15 MiB 8.41 MiB 1.26 MiB

Previous results on branch: lz/replay-stub-check

Startup times

Revision Plain With Sentry Diff
93d725f+dirty 367.48 ms 411.40 ms 43.92 ms
26b64bd+dirty 356.63 ms 413.25 ms 56.62 ms
0904b5b+dirty 354.26 ms 415.50 ms 61.24 ms
1dd4cb6+dirty 538.17 ms 562.26 ms 24.09 ms
1fc635a+dirty 363.53 ms 393.92 ms 30.39 ms

App size

Revision Plain With Sentry Diff
93d725f+dirty 7.15 MiB 8.43 MiB 1.28 MiB
26b64bd+dirty 7.15 MiB 8.42 MiB 1.26 MiB
0904b5b+dirty 7.15 MiB 8.43 MiB 1.28 MiB
1dd4cb6+dirty 7.15 MiB 8.43 MiB 1.28 MiB
1fc635a+dirty 7.15 MiB 8.43 MiB 1.28 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.12 ms 1257.18 ms 17.06 ms
Size 2.63 MiB 4.00 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
90afdd3+dirty 1233.90 ms 1240.90 ms 7.00 ms
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
6fee48d+dirty 1222.14 ms 1231.44 ms 9.30 ms
170d5ea+dirty 1219.27 ms 1231.90 ms 12.63 ms
1853710+dirty 1224.35 ms 1230.18 ms 5.84 ms
bc9680d+dirty 1221.41 ms 1241.47 ms 20.06 ms
20d5eaa+dirty 1231.12 ms 1226.00 ms -5.12 ms
276d348+dirty 1224.22 ms 1227.38 ms 3.16 ms
c7f264b+dirty 1211.82 ms 1218.04 ms 6.22 ms
a31630c+dirty 1229.09 ms 1230.94 ms 1.85 ms

App size

Revision Plain With Sentry Diff
90afdd3+dirty 2.63 MiB 3.99 MiB 1.35 MiB
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
6fee48d+dirty 2.63 MiB 3.96 MiB 1.33 MiB
170d5ea+dirty 2.63 MiB 3.98 MiB 1.35 MiB
1853710+dirty 2.63 MiB 3.91 MiB 1.28 MiB
bc9680d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
20d5eaa+dirty 2.63 MiB 3.81 MiB 1.18 MiB
276d348+dirty 2.63 MiB 3.98 MiB 1.34 MiB
c7f264b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
a31630c+dirty 2.63 MiB 3.98 MiB 1.34 MiB

Previous results on branch: lz/replay-stub-check

Startup times

Revision Plain With Sentry Diff
0904b5b+dirty 1221.90 ms 1210.30 ms -11.60 ms
93d725f+dirty 1215.06 ms 1214.96 ms -0.10 ms
1dd4cb6+dirty 1210.90 ms 1224.42 ms 13.52 ms
26b64bd+dirty 1231.79 ms 1236.35 ms 4.56 ms
1fc635a+dirty 1219.59 ms 1231.59 ms 12.00 ms

App size

Revision Plain With Sentry Diff
0904b5b+dirty 2.63 MiB 4.00 MiB 1.36 MiB
93d725f+dirty 2.63 MiB 3.99 MiB 1.36 MiB
1dd4cb6+dirty 2.63 MiB 3.99 MiB 1.35 MiB
26b64bd+dirty 2.63 MiB 3.98 MiB 1.34 MiB
1fc635a+dirty 2.63 MiB 3.99 MiB 1.35 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.37 ms 1229.53 ms 1.16 ms
Size 3.19 MiB 4.56 MiB 1.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
90afdd3+dirty 1216.17 ms 1225.55 ms 9.38 ms
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms
6fee48d+dirty 1208.85 ms 1218.52 ms 9.67 ms
170d5ea+dirty 1233.96 ms 1242.54 ms 8.58 ms
1853710+dirty 1213.67 ms 1226.35 ms 12.67 ms
bc9680d+dirty 1228.57 ms 1233.64 ms 5.07 ms
20d5eaa+dirty 1224.67 ms 1223.16 ms -1.51 ms
276d348+dirty 1222.10 ms 1229.02 ms 6.92 ms
c7f264b+dirty 1229.78 ms 1225.84 ms -3.94 ms
a31630c+dirty 1241.32 ms 1226.98 ms -14.34 ms

App size

Revision Plain With Sentry Diff
90afdd3+dirty 3.19 MiB 4.55 MiB 1.37 MiB
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB
6fee48d+dirty 3.19 MiB 4.53 MiB 1.35 MiB
170d5ea+dirty 3.19 MiB 4.55 MiB 1.36 MiB
1853710+dirty 3.19 MiB 4.48 MiB 1.29 MiB
bc9680d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
20d5eaa+dirty 3.19 MiB 4.38 MiB 1.19 MiB
276d348+dirty 3.19 MiB 4.54 MiB 1.36 MiB
c7f264b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
a31630c+dirty 3.19 MiB 4.54 MiB 1.36 MiB

Previous results on branch: lz/replay-stub-check

Startup times

Revision Plain With Sentry Diff
0904b5b+dirty 1231.65 ms 1235.65 ms 4.01 ms
93d725f+dirty 1217.04 ms 1220.55 ms 3.51 ms
1dd4cb6+dirty 1223.71 ms 1216.79 ms -6.92 ms
26b64bd+dirty 1228.94 ms 1244.28 ms 15.34 ms
1fc635a+dirty 1218.21 ms 1229.39 ms 11.18 ms

App size

Revision Plain With Sentry Diff
0904b5b+dirty 3.19 MiB 4.56 MiB 1.38 MiB
93d725f+dirty 3.19 MiB 4.56 MiB 1.37 MiB
1dd4cb6+dirty 3.19 MiB 4.55 MiB 1.37 MiB
26b64bd+dirty 3.19 MiB 4.54 MiB 1.36 MiB
1fc635a+dirty 3.19 MiB 4.55 MiB 1.37 MiB

@getsentry getsentry deleted a comment from github-actions bot Oct 2, 2025
@lucas-zimerman
Copy link
Collaborator Author

image

@lucas-zimerman
Copy link
Collaborator Author

image image image

@lucas-zimerman lucas-zimerman changed the title Ref: CI Check for Replay Stubs fix: CI Check for Replay Stubs Oct 9, 2025
@lucas-zimerman lucas-zimerman changed the title fix: CI Check for Replay Stubs Ref: CI Check for Replay Stubs Oct 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

Warnings
⚠️

🤖 Replay Stubs Check

No changes detected in replay-stubs.jar

All file contents are identical (verified by SHA-256 hash comparison).

Generated by 🚫 dangerJS against abbd632

@lucas-zimerman lucas-zimerman marked this pull request as ready for review October 29, 2025 10:38
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes and the linked test runs LGMT 🚀
Thank you for adding this check Lucas🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants