-
-
Couldn't load subscription status.
- Fork 4.5k
feat(prevent): Update repo selector for single app #102282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ccf1e2 to
40e8bc4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102282 +/- ##
========================================
Coverage 80.96% 80.96%
========================================
Files 8768 8768
Lines 389658 389621 -37
Branches 24780 24768 -12
========================================
- Hits 315469 315449 -20
+ Misses 73811 73794 -17
Partials 378 378 |
e8dc011 to
3fd0584
Compare
3fd0584 to
e784be0
Compare
efe9d27 to
5c13269
Compare
5c13269 to
93a064a
Compare
b9493c7 to
8945a59
Compare
03c7cd9 to
fb3bf11
Compare
| searchTerm: debouncedSearch, | ||
| }); | ||
|
|
||
| const scrollParentRef = useRef<HTMLElement | null>(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all these refs needed to manage the infinite scroll behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if get close to the bottom of the list, we trigger fetch of the next page of repos
|
|
||
| function ManageReposToolbar({ | ||
| installedOrgs, | ||
| integratedOrgs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might be more apt to name this dropdown or selector rather than toolbar (assuming this is the repo selector component, if not then ignore me 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically this component has both the org dropdown and the repo dropdown within it so may just leave it for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
We are moving to a single app (sentry gh app) instead of requiring both seer github app and sentry github app. As a result, we can just use existing endpoints (including search) for onboarded repos with sentry github integration. Cut over frontend to use those.
This PR includes:
getsentrythat has 1,000 reposgetsentry/sentry({ghorgname}/{ghreponame}) so do further filtering on client side so matches on the org name don't count as found repos.sentry_integrationtable