feat(scopes): Use project:distribution permission for check-for-updates endpoint #102295
+38
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new ProjectDistributionPermission class that uses the project:distribution scope for read access. Update the preprodartifacts/check-for-updates endpoint to use this new permission, allowing integration tokens with the distribution permission to access the endpoint.
github-actions
bot
added
the
Scope: Backend
runningcode
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102295 +/- ##
===========================================
+ Coverage 80.61% 80.96% +0.35%
===========================================
Files 8755 8755
Lines 389223 389374 +151
Branches 24730 24730
===========================================
+ Hits 313775 315272 +1497
+ Misses 75094 73748 -1346
Partials 354 354 |
chromy
approved these changes
Oct 29, 2025
|
Thanks, I have one here: #102298 |
Include project:distribution alongside org:admin and project:admin scopes to ensure the token has both general project access and the specific distribution permission.
Switch from user auth tokens to organization integration tokens (OrgAuthToken) for the check-for-updates endpoint tests. Integration tokens are the appropriate authentication method for API-to-API communication and work correctly with the project:distribution permission scope. The previous approach using user auth tokens with multiple scopes (org:admin, project:admin, project:distribution) was causing 403 errors because the permission system expected proper organization-level integration tokens for this type of endpoint access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
project:distributionpermission scope to enable fine-grained access control for distribution-related endpoints.Changes
ProjectDistributionPermissionclass insrc/sentry/api/bases/project.pythat uses theproject:distributionscope for GET requestspreprodartifacts/check-for-updatesendpoint to useProjectDistributionPermissioninstead ofProjectReleasePermissionNote
This will break any existing distribution tokens and update checks!