feat: better error message display #1222
Open
+33
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the error message display mechanism from a JavaScript DOM manipulation approach to a React-based ErrorBoundary component, improving code maintainability and consistency.
Key Changes:
- Replaced DOM injection error handling with React ErrorBoundary from @sentry/react
- Created a new ErrorFallback component to display user-friendly error messages
- Moved gradient background styling from TelemetryView to App component for consistent error screen appearance
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/spotlight/src/ui/App.tsx | Added ErrorBoundary with ErrorFallback component and moved gradient background wrapper to encompass error states |
| packages/spotlight/src/ui/telemetry/components/TelemetryView.tsx | Removed gradient background div wrapper (moved to App) and replaced with React Fragment |
| packages/spotlight/src/electron/main/index.ts | Removed JavaScript-based error screen DOM injection logic and showErrorMessage function |
| packages/spotlight/index.html | Removed CSS styles previously used for JavaScript-injected error screen |
| .changeset/orange-hands-smile.md | Added changeset documenting the error message display update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MathurAditya724
had a problem deploying
to
Preview
GitHub Actions
Error
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
betegon
reviewed
Dec 24, 2025
Member
Author
|
Updated the PR description with the video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview of how this will look, this will be shown on both web and electron app
Screen.Recording.2025-12-24.at.4.50.34.PM.mov