Open
Conversation
|
Yes, we did something like this - added possible use custom sidekiq worker #56. |
Contributor
|
I like it. It's cleaner than the current monkey patching I'm doing. Now, if we could remove the hard dependency on |
MiroslavCsonka
added a commit
to MiroslavCsonka/vero
that referenced
this pull request
Mar 18, 2021
MiroslavCsonka
added a commit
to MiroslavCsonka/vero
that referenced
this pull request
Mar 18, 2021
Comment on lines
+18
to
20
| def api_klass(api_class) | ||
| eval(api_class.to_s) | ||
| end |
There was a problem hiding this comment.
Using eval here introduces potential security risks since it executes arbitrary Ruby code. The safer approach is to use Rails' constantize method which is specifically designed for class name resolution: api_class.to_s.constantize
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one possible solution to #51 and #54. Essentially you can define your own SidekiqWorker class to send API requests to Vero.
Something like this...
and in
vero.rbWhat do you think @damienbrz, @shaneog, @lemboy, @criticerz?