Skip to content

update GLAD-L column names; fixes GTC-2509#177

Open
solomon-negusse wants to merge 4 commits intostagingfrom
fix-glad-L-alerts
Open

update GLAD-L column names; fixes GTC-2509#177
solomon-negusse wants to merge 4 commits intostagingfrom
fix-glad-L-alerts

Conversation

@solomon-negusse
Copy link

Copy link
Contributor

@tiagojsag tiagojsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the query response handling code? If a column name changes, not only do you need to modify the query, but also the logic that handles its response.

@solomon-negusse
Copy link
Author

Have you tested the query response handling code? If a column name changes, not only do you need to modify the query, but also the logic that handles its response.

Hm, it didn't look like the field was used from the response. Checking if I missed that..

@solomon-negusse
Copy link
Author

Have you tested the query response handling code? If a column name changes, not only do you need to modify the query, but also the logic that handles its response.

@tiagojsag: type hints and unit tests are updated with the field name change. may have to sync with you or let me know here if there's any more update I missed.

@solomon-negusse solomon-negusse changed the base branch from dev to staging September 28, 2023 15:35
@solomon-negusse solomon-negusse mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants