Updated guzzle deps to support 6.* OR 7.* for compatibility.#33
Open
RickKukiela wants to merge 2 commits intoghassani:masterfrom
Open
Updated guzzle deps to support 6.* OR 7.* for compatibility.#33RickKukiela wants to merge 2 commits intoghassani:masterfrom
RickKukiela wants to merge 2 commits intoghassani:masterfrom
Conversation
RickKukiela
commented
Dec 29, 2022
RickKukiela
commented
- src/Client.php: Fixed missing parameter name in a phpDocBlock comment.
- src/Authenticator.php: Fixed bad phpDocBlock comments / Added extra catch for GuzzleException since that class does not appear to extend \Exception and \Throwable cannot be used here since we need to support < php7.1
- Updated ContactTest.php to assert an error value is not returned on all API calls and to spit out the error message returned to the command line in the event of a failed test.
- Update the composer.json deps to support guzzle 6 and/or guzzle 7, also added dev requirement for phpunit.
- Added .phpunit.result.cache file to .gitignore
- src/Client.php: Fixed missing parameter name in a phpDocBlock comment. - src/Authenticator.php: Fixed bad phpDocBlock comments / Added extra catch for GuzzleException since that class does not appear to extend \Exception and \Throwable cannot be used here since we need to support < php7.1 - Updated ContactTest.php to assert an error value is not returned on all API calls and to spit out the error message returned to the command line in the event of a failed test. - Update the composer.json deps to support guzzle 6 and/or guzzle 7, also added dev requirement for phpunit. - Added .phpunit.result.cache file to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.