feat(install): support custom node bin path in shebang#225
Open
josephschmitt wants to merge 1 commit intoghooks-org:masterfrom
Open
feat(install): support custom node bin path in shebang#225josephschmitt wants to merge 1 commit intoghooks-org:masterfrom
josephschmitt wants to merge 1 commit intoghooks-org:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 99 107 +8
Branches 4 4
=====================================
+ Hits 99 107 +8
Continue to review full report at Codecov.
|
josephschmitt
force-pushed
the
node-bin
branch
3 times, most recently
from
835b228 to
5cc208c
Compare
The custom path is set in the ghooks config right now because I couldn't think of a better place for it. Let me know if you have a better idea.
Collaborator
|
Once again, thank you for the contribution! That's a nice customization! Is this an issue you're currently experiencing? Regarding where to put ghooks "settings", we've discussed it in the past #81. Haven't reached a consensus, though… But I think that #81 (comment) can be a good first step… Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom path is set in the ghooks config right now because I couldn't think of a better place for it. Let me know if you have a better idea.