Move route bindings to declarative app-config for NFS#1442
Closed
Move route bindings to declarative app-config for NFS#1442
Conversation
Migrate route bindings to declarative config for NFS compatibility, removing the imperative bindRoutes callback from createApp.
Route IDs are {pluginId}.{routeName}, not {pluginId}.externalRoutes.{routeName}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates route bindings from the imperative
bindRoutescallback increateApp()to declarativeapp.routes.bindingsinapp-config.yaml, aligning with the New Frontend System (NFS) approach.What is the effect of this change to users?
No user-facing change. Route bindings behave identically when declared in config.
Any background context you can provide?
In NFS, route bindings are resolved from config using the
{pluginId}.{routeName}key format (built bycollectRouteIdsas${feature.id}.${name}). This replaces the legacybindRoutes({ bind })pattern.Do the docs need to be updated?
No.
Should this change be mentioned in the release notes?