Migrate cards from Material-UI to @backstage/ui Card system#1444
Closed
Migrate cards from Material-UI to @backstage/ui Card system#1444
Conversation
Migrate route bindings to declarative config for NFS compatibility, removing the imperative bindRoutes callback from createApp.
Route IDs are {pluginId}.{routeName}, not {pluginId}.externalRoutes.{routeName}.
Reorganize imports and features array by group (app, GS, upstream, legacy), move flux overrides from src/flux/ to src/modules/flux/ for consistency, and align flux module exports with other module patterns.
Move the ai-chat-verbose-debugging feature flag registration from the app-level AppOverrides module to the ai-chat plugin where it belongs.
Create a new InfoCard component in ui-react using @backstage/ui primitives (Card, CardHeader, CardBody, CardFooter, Text, Flex) to align with upstream Backstage's migration away from Material-UI based InfoCard. Migrate all 14 usages across gs and flux-react plugins to the new component.
Replace direct Material-UI Card+CardContent usage with the new InfoCard component in ClusterToolsCard, DeploymentToolsCard, ResourcesCard, and GitOpsCard for consistent card styling across the application.
Replace Material-UI Grid, Switch, FormGroup with @backstage/ui Flex, Grid.Root, and Switch components. Simplify AboutField by removing gridSizes prop and using plain div instead of Grid item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates all custom card components from Material-UI's
InfoCard(@backstage/core-components) and rawCard/CardContent(@material-ui/core) to the new@backstage/uiCard system, aligning with upstream Backstage's direction.InfoCardcomponent inui-reactbased on upstream'sEntityInfoCard, using@backstage/uiprimitives (Card,CardHeader,CardBody,CardFooter,Text,Flex)gsandflux-reactpluginsGrid,Switch,FormGroupwith@backstage/uiequivalents in card internalsAboutFieldby removinggridSizespropWhat is the effect of this change to users?
Cards will render with consistent styling matching upstream Backstage's modern card design, resolving the visual discrepancy between custom cards (e.g., "Deploy application") and upstream cards (e.g., "About").