Fix entity header icon disappearing on tab switch#1449
Merged
Conversation
The entity icon was only visible on the overview tab because EntityHeaderIcon was mounted inside HelmChartContentLayout, which unmounts on tab switch. Replace this with an EntityHeaderBlueprint that provides a custom header for entities with a GS icon annotation. The custom header mirrors the upstream EntityHeader (title, subtitle, labels, context menu, inspect dialog) and injects the icon via DOM manipulation into the header flex layout so it persists across all tabs.
marians
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the portal-based
EntityHeaderIconwith anEntityHeaderBlueprintcustom header so the entity icon persists across all tabs on catalog entity pages.Previously,
EntityHeaderIconwas mounted insideHelmChartContentLayout, which only renders on the overview tab. Switching to any other tab would unmount the component and the icon would disappear.