Add link to match page in getMatches() response#792
Open
valsouche wants to merge 1 commit intogigobyte:masterfrom
Open
Add link to match page in getMatches() response#792valsouche wants to merge 1 commit intogigobyte:masterfrom
valsouche wants to merge 1 commit intogigobyte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there, first of all: Thank you !
When you click on a match from the Matches page, the redirect URL is kind of not intuitive, there are some logics and concatenations from HLTV. Team names are cleaned (Virtus.pro --> virtuspro) for example.
We can find the logic and implement it but It's a bit error prone. By having the value from the response, we could make clean redirectToMatch URL 👍
My purpose is to add the
hrefvalue in thegetMatches()response in order to be able to create redirect link easily 🤷Thank you in advance.