Skip to content

Fix compiling error when enable debug#1

Open
minsii wants to merge 1 commit intogilbertlee-amd:RCCLSupportfrom
minsii:pr/RCCLSupport-debug-fix
Open

Fix compiling error when enable debug#1
minsii wants to merge 1 commit intogilbertlee-amd:RCCLSupportfrom
minsii:pr/RCCLSupport-debug-fix

Conversation

@minsii
Copy link

@minsii minsii commented Jan 31, 2022

What

ucc_tl_rccl_context_t *ctx was not defined but is used by ucc_assert. It caused compilation error (see below).

../../../../../src/components/tl/rccl/tl_rccl_coll.c: In function ‘ucc_tl_rccl_collective_sync’:
../../../../../src/components/tl/rccl/tl_rccl_coll.c:149:16: error: ‘ctx’ undeclared (first use in this function)
     ucc_assert(ctx->cfg.sync_type == UCC_TL_RCCL_COMPLETION_SYNC_TYPE_EVENT);

This commit fixes it. ctx will be defined when debug build is on (configure with --enable-debug)

@gilbertlee-amd gilbertlee-amd self-requested a review February 2, 2022 01:01
gilbertlee-amd added a commit that referenced this pull request Feb 2, 2022
MC/ROCM: add rocm support
TL/RCCL: add rccl support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments