Fix compiling error when enable debug#1
Open
minsii wants to merge 1 commit intogilbertlee-amd:RCCLSupportfrom
minsii:pr/RCCLSupport-debug-fix
Open
Fix compiling error when enable debug#1minsii wants to merge 1 commit intogilbertlee-amd:RCCLSupportfrom minsii:pr/RCCLSupport-debug-fix
minsii wants to merge 1 commit intogilbertlee-amd:RCCLSupportfrom
minsii:pr/RCCLSupport-debug-fix
Conversation
gilbertlee-amd
added a commit
that referenced
this pull request
Feb 2, 2022
MC/ROCM: add rocm support TL/RCCL: add rccl support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ucc_tl_rccl_context_t *ctxwas not defined but is used byucc_assert. It caused compilation error (see below).This commit fixes it.
ctxwill be defined when debug build is on (configure with --enable-debug)