Skip to content

Conversation

@MozhganPeivandianSharbaf
Copy link
Contributor

… after orientation change

IPC-717

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the payment review screen to prevent recreation after orientation changes, improving user experience by maintaining the screen state during device rotation.

Key changes:

  • Implement state preservation for ViewPager position and height across orientation changes
  • Add proper handling for keyboard state restoration after rotation
  • Update ViewPager2 and RecyclerView dependencies to newer versions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
ghs_fragment_review.xml Adds constraint height attribute to improve layout behavior
ReviewViewModel.kt Adds properties to store pager position and height state
ReviewFragment.kt Implements comprehensive orientation change handling with state preservation
libs.versions.toml Updates ViewPager2 and RecyclerView dependency versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

Copy link
Contributor

@obaidgini obaidgini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MozhganPeivandianSharbaf Looks good to me👌, just small comments, Can you please check, Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants