-
Notifications
You must be signed in to change notification settings - Fork 1
IPC 717 Refactor Payment Review Screen for not recreating after orientation change #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: IPC-716-refactor-for-accessibility
Are you sure you want to change the base?
Conversation
… after orientation change IPC-717
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the payment review screen to prevent recreation after orientation changes, improving user experience by maintaining the screen state during device rotation.
Key changes:
- Implement state preservation for ViewPager position and height across orientation changes
- Add proper handling for keyboard state restoration after rotation
- Update ViewPager2 and RecyclerView dependencies to newer versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ghs_fragment_review.xml | Adds constraint height attribute to improve layout behavior |
| ReviewViewModel.kt | Adds properties to store pager position and height state |
| ReviewFragment.kt | Implements comprehensive orientation change handling with state preservation |
| libs.versions.toml | Updates ViewPager2 and RecyclerView dependency versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Show resolved
Hide resolved
|
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
obaidgini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MozhganPeivandianSharbaf Looks good to me👌, just small comments, Can you please check, Thank you.
…rientation change IPC-717



… after orientation change
IPC-717