Implement T8L3/glossary-branch-delete

[jiaxinnns]

Exercise Review

Exercise Discussion

Fixes #238

Checklist

• If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
• Have you written unit tests using repo-smith to validate the exercise grading scheme?
• Have you tested your changes using the instructions posted?
• Have you verified that this exercise does not already exist or is not currently in review?
• Did you introduce a new grading mechanism that should belong to git-autograder?
• Did you introduce a new dependency that should belong to app?

[github-actions]

Hi @jiaxinnns, thank you for your contribution! 🎉

This PR comes from your fork jiaxinnns/exercises on branch feature/glossary-branch-delete.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "jiaxinnns",
        "repository": "exercises",
        "branch": "feature/glossary-branch-delete"
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

• (For exercises and hands-ons) I have verified that the downloading behavior works
• (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

[jovnc]

Thanks for the work! Just some minor adjustments needed and details to sort out!

[jovnc]

Currently, download.py doesn't fetch branch VWX as well, so local repository would only have main branch. If we want VWX in local repository as well, we can add a step to fetch it from remote as well.

While the exercise instruction does state to delete both local and remote VWX branches, I think it may not be necessary to add in this logic since the purpose of the exercise is to test students interacting with remote repositories.

@damithc Do you think we should remove deleting local branch VWX or stick to the current exercise that requires students to delete both local and remote branches?

[jovnc]

Tested and works well!

[jovnc]

Observed behaviour:

gh repo clone clones all remote branches but doesn't clone it locally first, but when you switch to that branch, it will automatically create that branch and track it.

[jovnc]

LGTM