Skip to content

Update repo config#275

Open
desmondwong1215 wants to merge 1 commit intogit-mastery:mainfrom
desmondwong1215:infra/update-repo-config
Open

Update repo config#275
desmondwong1215 wants to merge 1 commit intogit-mastery:mainfrom
desmondwong1215:infra/update-repo-config

Conversation

@desmondwong1215
Copy link
Copy Markdown
Contributor

Update repo config to run the tests.

@github-actions
Copy link
Copy Markdown

Hi @desmondwong1215, thank you for your contribution! 🎉

This PR comes from your fork desmondwong1215/exercises on branch infra/update-repo-config.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "desmondwong1215",
        "repository": "exercises",
        "branch": "infra/update-repo-config"
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

  • (For exercises and hands-ons) I have verified that the downloading behavior works
  • (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

@desmondwong1215
Copy link
Copy Markdown
Contributor Author

Need to rerun the tests after git-mastery/git-autograder#22 is merged.

Copy link
Copy Markdown
Contributor

@SAN-MUYUN SAN-MUYUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

create_fork=None,
init=True,
pr_number=None,
pr_repo_full_name=None,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants