Conversation
|
Hi @jovnc, thank you for your contribution! 🎉 This PR comes from your fork Before you request for a review, please ensure that you have tested your changes locally! Important The previously recommended way of using Please read the following instructions for the latest instructions. PrerequisitesEnsure that you have the Testing stepsIf you already have a local Git-Mastery root to test, you can skip the following step. Create a Git-Mastery root locally: gitmastery setupNavigate into the Git-Mastery root (defaults to cd gitmastery-exercises/Edit the {
# other fields...
"exercises_source": {
"username": "jovnc",
"repository": "exercises",
"branch": "chore/update-setup-script"
}
}Then, you can use the gitmastery download <your new change>
gitmastery verifyChecklist
Important To any reviewers of this pull request, please use the same instructions above to test the changes. |
VikramGoyal23
left a comment
There was a problem hiding this comment.
LGTM, but IMO the import commands at the top help enforce the programming style a bit. Should we consider leaving the run_command import(s)? Other changes are good.
|
We shouldn't be encouraging the use of |
|
Coding style is no problem, as we have linters and formatters in place |
jiaxinnns
left a comment
There was a problem hiding this comment.
Agree that run_command should be avoided and the import can mislead new developers into thinking otherwise. LGTM
|
I was referring to the style of import ( |
Summary
Update set up scripts to remove unnecessary code in boilerplate for hands on and exercises