Introducing declarative Python syntax over YAML syntax#9
Conversation
This is so we don't need to embed Git-Mastery specific logic into this class but we still want to ensure that all Helpers are initialized in a consistent manner
jovnc
left a comment
jovnc
left a comment
There was a problem hiding this comment.
Left some comments in case you missed out some minor details.
Also, with this change, it looks like we can do some cleaning on the repository as well, and remove old tests, eg. the YAML test. We also need to update specification.md to reflect this latest change.
jovnc
left a comment
jovnc
left a comment
There was a problem hiding this comment.
Overall LGTM
Should we also clean up the repository to remove traces of old specifications? This can cause confusion to new developers who aren't aware of the previous YAML spec.
- update specification.md
- update tests to reflect this changes
- remove unnecessary tests, eg. spec files, integration tests
|
I'm inclined to do these changes after we've merged everything into exercises first. I would want to cut the release for this change ASAP so that if there's any issues, we can immediately test for it. I'll make a PR to clean everything up and add full unit testing |
|
Teardown PR started here: #10 |
2 participants
Full RFC: https://docs.google.com/document/d/1kko6PP1A7OjXn6A994XC9M7IQMrzswwRDBs839XW_qQ/edit?tab=t.0
The core idea is for us to migrate away from a clunky and hard to maintain third-party YAML syntax in favor of a more declarative Python syntax so we embed the setup code within the unit tests.
There are hopes for us to use this for setting up repositories, but for now, we are sticking to using these for unit tests