Replace computer monitor on homepage #2105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To1ne
reviewed
Oct 30, 2025
assets/sass/front-page.scss
Outdated
|
|
||
| &:hover { | ||
| background-image: linear-gradient(#1a7e84, #165b60); | ||
| transform: translateY(-1px); |
There was a problem hiding this comment.
I'm not a fan of this effect. To me it would feel more natural if the button moves down on hover. But I think I would prefer a highlighted border or something (I haven't decided yet).
There was a problem hiding this comment.
I can just change the background colour instead, I think that's more in line with what the other buttons on the site do
There was a problem hiding this comment.
It's a bit tricky to find hover background colours that work both in dark mode and light mode so I just removed the hover effect
jvns
force-pushed
the
homepage-monitor
branch
from
b67a1de to
9fdb5a2
Compare
Co-authored-by: Marie Claire LeBlanc Flanagan <hello@marieflanagan.com>
jvns
force-pushed
the
homepage-monitor
branch
from
9fdb5a2 to
b509051
Compare
jvns
force-pushed
the
homepage-monitor
branch
from
b509051 to
6512c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the computer monitor on the homepage (and the links below it) with a single box.
You can see it in action here: https://jvns.github.io/git-scm.com/
I'm not totally sure about the "GitHub Repository" link, since it says elsewhere that technically the GitHub repo is a "mirror", but I think it is an official mirror and it's the most convenient way (at least for me) to view the current version of the source code.
I've removed the links below the monitor. Here's the new way to access the removed links, open to hearing that they should be made more prominent.
I expect this has the same issues with the screenshot not matching as #2088, haven't dealt with that yet.
Also I need to run the WCAG checker on this contrast in dark mode, not sure it's high enough.