feat(args): completely rework args crate #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-noland
force-pushed
the
pr/daniel-noland/rework-args
branch
from
96097cd to
a39ef0a
Compare
daniel-noland
requested review from
Copilot and
sergeymatov
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors dataplane configuration management by moving common types and constants from their previous locations into the args crate, and introduces a new configuration serialization system using sealed memory files (memfds). The key changes enable the dataplane-init process to pass ephemeral launch-time configuration to child dataplane processes.
- Moved socket path constants (
DEFAULT_DP_UX_PATH,DEFAULT_DP_UX_PATH_CLI,DEFAULT_FRR_AGENT_PATH) fromrouting::riotoargsmodule - Moved
GrpcAddressenum frommgmt::processor::launchtoargsmodule with enhanced serialization support - Added extensive new configuration infrastructure including
MemFile,FinalizedMemFile,LaunchConfiguration, and integrity checking using SHA384 - Removed DPDK-specific command-line arguments and the unused
setup_pipelinefunction fromdataplane/src/main.rs
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| routing/src/router.rs | Updated imports to use socket path constants from args instead of crate::rio |
| routing/src/rio.rs | Removed socket path constants (moved to args), updated references to use args:: prefix |
| routing/Cargo.toml | Added dependency on args workspace crate |
| mgmt/src/processor/launch.rs | Removed GrpcAddress enum (moved to args), updated to use args::GrpcAddress, changed to_path_buf() to into(), fully qualified tokio::task::spawn |
| mgmt/Cargo.toml | Added dependency on args workspace crate, reordered dependencies alphabetically |
| dataplane/src/main.rs | Removed unused imports and setup_pipeline function, replaced method calls with new naming (grpc_address(), driver_name()), replaced DPDK driver start with todo!() |
| args/src/lib.rs | Added socket path constants, GrpcAddress enum, extensive memfd infrastructure, LaunchConfiguration types, integrity checking, conversion from CmdArgs to LaunchConfiguration, renamed methods, moved test code |
| args/Cargo.toml | Added many new dependencies (miette, sha2, memmap2, nix, bytecheck, serde, etc.), reordered and reorganized dependencies |
| Cargo.lock | Added new transitive dependencies for the new functionality |
mvachhar
requested changes
Nov 4, 2025
Contributor
mvachhar
left a comment
mvachhar
left a comment
There was a problem hiding this comment.
Please address the copilot comments and partition lib.rs into a few files as described. Otherwise, this looks good.
daniel-noland
force-pushed
the
pr/daniel-noland/rework-args
branch
2 times, most recently
from
d583e1b to
fed2308
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/rework-args
branch
from
fed2308 to
84e5508
Compare
The args crate is now has a wider scope: it is not just responsible for parsing and validating arguments, it is (partly) responsible for handing the dataplane a memfd file with parsed and acted on data. The idea here is to 1. allow all of the highly sensitive, highely privileged, and one off jobs to be done by dataplane-init rather than dataplane 2. so that dataplane can init the DPDK eal as quickly as possible after process start. The memfd strategy (developed in this PR), is a relatively simple way to accomplish these objectives (although there is a lot of room for improvement here). Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Signed-off-by: Daniel Noland <daniel@githedgehog.com>
daniel-noland
force-pushed
the
pr/daniel-noland/rework-args
branch
from
84e5508 to
c0a4cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broken out from #964 in order to help @Fredi-raspall do any needed rebase work.
Ideally we can keep getting chunks of #964 in as we progress in integration.
Note
I also significantly extended the docs vs what is currently in #964