fix: move workflow permissions from job level to workflow level#359
Draft
fix: move workflow permissions from job level to workflow level#359
Conversation
Job-level permissions are capped by workflow-level permissions. With workflow-level set to only `contents: read`, job-level write permissions were silently capped, breaking actions like markPullRequestReadyForReview.
jmeridth
force-pushed
the
fix/workflow-permissions-to-workflow-level
branch
from
f7aa355 to
5c617cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves permissions declarations from job level back to workflow level across all workflow files.
Why
Workflow-level
permissionssets the maximum token permissions for all jobs. Withcontents: readat workflow level, job-levelcontents: writewas silently capped, causingResource not accessible by integrationerrors (e.g.,markPullRequestReadyForReviewin mark-ready-when-ready).Notes