Skip to content
This repository was archived by the owner on Feb 5, 2018. It is now read-only.

Conversation

@mkcode
Copy link

@mkcode mkcode commented Oct 8, 2015

@PeterDaveHello - Thanks for your contribution. I'm using this work as an opportunity to clean up how we are doing testing in this app. I see that you basically copied the format from the create_repos spec - which was a good move.

After reworking this so I can understand what is happening in be8a8b1, I notice that we are not stubbing any repo deletion requests - which then therefore would mean that these tests aren't actually sending any API requests.

@PeterDaveHello - these tests should be hitting a delete repo endpoint on the GitHub API, should they not? Can we rework them so that they do? These tests should fail in the case the we comment out the teachers_pet(:delete_repos)... block.

/cc @johndbritton

@PeterDaveHello
Copy link

@mkcode did you mean you want me to create a new PR that asking merging from delete-repos-cleanup to master branch? Thanks.

From #113 (comment):

@PeterDaveHello - I added to this PR in #126. Can you please take a look at #126 and create a new PR targeting the delete-repos-cleanup branch? Thanks!

@mkcode
Copy link
Author

mkcode commented Feb 10, 2016

@mkcode did you mean you want me to create a new PR that asking merging from delete-repos-cleanup to master branch? Thanks.

If it is possible, that would be great!

@PeterDaveHello
Copy link

If it is possible, that would be great!

@mkcode sure I will, sorry for the late reply.

@PeterDaveHello
Copy link

temp

@mkcode seems I cannot because of "this" PR was sent, maybe you can just merge this one? 😄

@mkcode
Copy link
Author

mkcode commented Feb 17, 2016

@PeterDaveHello - With GitHub Pull Requests - you can add more commits to this existing PR. Really handy! Do the following:

cd teachers_pet # in this repo dir
git checkout delete-repos-cleanup # checkout this branch
git pull # pull 

Then you are setup to commit and run git push origin delete-repos-cleanup again to add to this PR.

@PeterDaveHello
Copy link

@mkcode sorry that I didn't really get the point, would you please tell me the url if origin in your example? Is this repo or the forked repo? I confused should I create a new PR or not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants