Skip to content

Add key concepts to JCA model #18852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knewbury01 wants to merge 32 commits into from

Add model and sample query for constants used in key specs

95544e2
Select commit
Loading
Failed to load commit list.
Closed

Add key concepts to JCA model #18852

Add model and sample query for constants used in key specs
95544e2
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Feb 24, 2025 in 12s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (rust-analysis.yml)

  • ❓  .github/workflows/rust-analysis.yml:analyze/language:rust

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 41 warnings
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 4 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in OpenSSLModel should be PascalCase/camelCase.

Check warning on line 17 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in AlgorithmToEVPKeyDeriveConfig should be PascalCase/camelCase.

Check warning on line 25 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in AlgorithmToEVPKeyDeriveFlow should be PascalCase/camelCase.

Check warning on line 107 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 129 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 136 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 149 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in KDFAlgorithmStringLiteral should be PascalCase/camelCase.

Check warning on line 161 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in algorithmStringToKDFFetchArgFlow should be PascalCase/camelCase.

Check warning on line 170 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check notice on line 173 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Field only used in CharPred Note

Field is only used in CharPred.

Check warning on line 193 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 220 in cpp/ql/lib/experimental/Quantum/OpenSSL.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 5 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in JCAModel should be PascalCase/camelCase.

Check warning on line 62 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in JCACipherOperationCall should be PascalCase/camelCase.

Check warning on line 74 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelling', which should instead be 'modeling'.

Check warning on line 278 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelled', which should instead be 'modeled'.

Check warning on line 412 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 429 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in GCMParameterSpecInstance should be PascalCase/camelCase.

Check warning on line 449 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Expression can be replaced with a cast Warning

The assignment to
m
Loading
in the exists(..) can replaced with an instanceof expression.

Check warning on line 539 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 552 in java/ql/lib/experimental/Quantum/JCA.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 36 in java/ql/lib/experimental/Quantum/Language.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 36 in java/ql/lib/experimental/Quantum/Language.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelled', which should instead be 'modeled'.

Check warning on line 17 in java/ql/src/experimental/Quantum/BrokenCrypto.ql

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelling', which should instead be 'modeling'.

Check warning on line 14 in java/ql/src/experimental/Quantum/ConstantPassword.ql

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelling', which should instead be 'modeling'.