Conversation
redsun82
force-pushed
the
reddsun82/swift-ql-test-to-internal
branch
3 times, most recently
from
4f59145 to
8691b1c
Compare
redsun82
added
the
depends on internal PR
* remove ql test running and upgrade/downgrade scripts checking (now done internally) * removed all the bazel caching stuff, that never really worked any way * moved `misc/codegen` generic testing to a separate workflow, as it's not swift specific any more * reinstanted checking that the extractor can be built locally from the `codeql` repo.
redsun82
force-pushed
the
reddsun82/swift-ql-test-to-internal
branch
from
8691b1c to
622aa7c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the CodeQL workflow for Swift by removing redundant test scripts and caching, refactoring workflow triggers, and isolating generic codegen tasks.
- Added a new Codegen workflow with formatting checks and bazel tests.
- Updated the Swift workflow to use a matrix for build-and-test and updated the codegen target command.
- Removed deprecated push triggers and unused scripts.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/codegen.yml | Added a new workflow file to run code generation tests. |
| .github/workflows/swift.yml | Updated workflow triggers, job names, and commands for Swift CI. |
Files not reviewed (4)
- swift/actions/build-and-test/action.yml: Language not supported
- swift/actions/database-upgrade-scripts/action.yml: Language not supported
- swift/actions/run-ql-tests/action.yml: Language not supported
- swift/actions/share-extractor-pack/action.yml: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/swift.yml:72
- Removing the fully qualified label for the codegen target may cause incorrect target resolution if the target is not defined in the working directory set by defaults.
bazel run codegen -- --generate=trap,cpp --cpp-output=$PWD/generated-cpp-files
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
redsun82
removed
the
depends on internal PR
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: bazelbuild/setup-bazelisk@v2 |
There was a problem hiding this comment.
Do you no longer need this? Are you getting Bazel from the Actions image then?
There was a problem hiding this comment.
indeed, see actions/runner-images#221 (comment). To be noted, is that on all images bazel actually points to a bazelisk binary, which means the correct bazel version from .bazelversion will be used.
There was a problem hiding this comment.
(see for example https://github.com/github/codeql/actions/runs/13896248292/job/38877429011?pr=19029#step:4:5 where bazelisk reports downloading the required version)
2 participants
misc/codegengeneric testing to a separate workflow, as it's not swift specific any morecodeqlrepo on both macOS and Linux.